WPF MVVM元素可见性切换问题求助及代码优化建议

核心问题排查与修复 #

1. MyCommand类实现错误 #

你提供的MyCommand代码完全重复了ViewModelBase，正确的ICommand实现应该是：

public class MyCommand : ICommand
{
    private readonly Action<object> _execute;
    private readonly Func<object, bool> _canExecute;

    public event EventHandler? CanExecuteChanged;

    public MyCommand(Action<object> execute, Func<object, bool> canExecute = null)
    {
        _execute = execute ?? throw new ArgumentNullException(nameof(execute));
        _canExecute = canExecute;
    }

    public bool CanExecute(object? parameter)
    {
        return _canExecute?.Invoke(parameter ?? null) ?? true;
    }

    public void Execute(object? parameter)
    {
        _execute(parameter ?? null);
    }

    public void RaiseCanExecuteChanged()
    {
        CanExecuteChanged?.Invoke(this, EventArgs.Empty);
    }
}

2. MMViewModel未实例化Model对象 #

MMViewModel中的M字段未定义和实例化，同时MyModel的字段应封装为属性：

修复后的MyModel

class MyModel
{
    public Visibility MyVisibility { get; set; }
}

修复后的MMViewModel

public class MMViewModel : ViewModelBase
{
    private readonly MyModel _model;

    public MMViewModel()
    {
        _model = new MyModel();
    }

    public Visibility MyVisibility
    {
        get { return _model.MyVisibility; }
        set
        {
            if (_model.MyVisibility != value)
            {
                _model.MyVisibility = value;
                OnPropertyChanged(nameof(MyVisibility));
            }
        }
    }
}

3. MyViewModel类名与构造函数名不一致 #

构造函数名MyVievModel拼写错误，应与类名MyViewModel一致，同时优化属性定义：

public class MyViewModel : ViewModelBase
{
    private ICommand _myCommand;
    private ObservableCollection<MMViewModel> _mm1;

    public ObservableCollection<MMViewModel> MM1
    {
        get => _mm1;
        set
        {
            _mm1 = value;
            OnPropertyChanged(nameof(MM1));
        }
    }

    public ICommand MyButtonClickCommand
    {
        get => _myCommand;
        set
        {
            _myCommand = value;
            OnPropertyChanged(nameof(MyButtonClickCommand));
        }
    }

    public MyViewModel()
    {
        MM1 = new ObservableCollection<MMViewModel>();
        MM1.Add(new MMViewModel
        {
            MyVisibility = Visibility.Visible
        });
        _myCommand = new MyCommand(ChangeVis, ToEvaluate);
    }

    private void ChangeVis(object context)
    {
        var item = context as MMViewModel;
        if (item != null)
        {
            item.MyVisibility = item.MyVisibility == Visibility.Visible ? Visibility.Hidden : Visibility.Visible;
        }
    }

    private bool ToEvaluate(object context)
    {
        return true;
    }
}

这里优化了ChangeVis方法，支持传入当前MMViewModel实例，实现可见性切换（而非仅隐藏）。

4. XAML绑定错误修复 #

• Button的Command需要绑定到父ViewModel的MyButtonClickCommand，使用RelativeSource获取上级ItemsControl的DataContext
• StackPanel的Visibility应绑定到MMViewModel的MyVisibility属性

<StackPanel>
    <ItemsControl ItemsSource="{Binding Path=MM1}">
        <ItemsControl.ItemTemplate>
            <DataTemplate>
                <Grid Background="Black">
                    <Grid.ColumnDefinitions>
                        <ColumnDefinition/>
                        <ColumnDefinition/>
                    </Grid.ColumnDefinitions>
                    <Border BorderBrush="Blue" BorderThickness="2" Grid.ColumnSpan="2"/>
                    <StackPanel Grid.Column="0">
                        <Button VerticalAlignment="Center"
                                Content="What is Netflix?"
                                FontSize="30"
                                Foreground="White"
                                Command="{Binding DataContext.MyButtonClickCommand, RelativeSource={RelativeSource AncestorType=ItemsControl}}"
                                CommandParameter="{Binding}">
                        </Button>
                        <TextBlock Grid.Column="1" 
                                   HorizontalAlignment="Right" 
                                   Text="+"
                                   FontSize="60" 
                                   Foreground="White"/>
                        <StackPanel Margin="0 5 0 0" 
                                    Visibility="{Binding MyVisibility, Mode=OneWay}">
                            <TextBlock Foreground="White" FontSize="20">Text1<LineBreak/> Text1 continue</TextBlock>
                            <TextBlock Margin="0 20 0 0" Foreground="White" FontSize="20">Text2</TextBlock>
                        </StackPanel>
                    </StackPanel>
                </Grid>
            </DataTemplate>
        </ItemsControl.ItemTemplate>
    </ItemsControl>
</StackPanel>

• 给Button添加了CommandParameter，将当前MMViewModel实例传递给命令，实现精准控制
• Visibility绑定改为OneWay（无需双向绑定，由ViewModel驱动View即可）

代码优化建议 #

• ViewModelBase优化：使用null条件运算符简化OnPropertyChanged，同时支持CallerMemberName避免硬编码属性名：

using System.Runtime.CompilerServices;

public abstract class ViewModelBase : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler? PropertyChanged;

    protected void OnPropertyChanged([CallerMemberName] string propertyName = "")
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
    }
}

这样在属性setter中只需调用OnPropertyChanged()，无需传入属性名。

• 使用RelayCommand替代自定义MyCommand：WPF社区常用RelayCommand（与上述MyCommand实现类似），可以直接使用Prism.Mvvm包中的RelayCommand，减少重复代码。
• 字段封装：所有字段都应封装为属性，避免直接暴露字段（如MyModel中的原myVisibility字段）。
• 命名规范：严格遵守C#命名规范，类名、属性名使用PascalCase，字段使用_camelCase。

内容的提问来源于stack exchange，提问作者ParnayaBylochka