3D向量类编译报错：非const左值引用绑定失败及拷贝构造器警告

问题描述 #

调试3D向量代码时出现两个问题：

• 编译错误：在cvector3D.h的cvector operator*(double, cvector)函数中，无法将cvector&类型的非const左值引用绑定到cvector类型的右值
• 警告：class "cvector" has no suitable copy constructor

编译错误详情 #

/usr/bin/g++ -fdiagnostics-color=always -g /home/fangrui/vectorFEM/vectorFEM/main.cpp -o /home/fangrui/vectorFEM/vectorFEM/main
In file included from /home/fangrui/vectorFEM/vectorFEM/constant.h:6:0,
                 from /home/fangrui/vectorFEM/vectorFEM/mesh.h:2,
                 from /home/fangrui/vectorFEM/vectorFEM/edgenedelec.h:2,
                 from /home/fangrui/vectorFEM/vectorFEM/main.cpp:1:
/home/fangrui/vectorFEM/vectorFEM/cvector3D.h: In function ‘cvector operator*(double, cvector)’:
/home/fangrui/vectorFEM/vectorFEM/cvector3D.h:39:10: error: cannot bind non-const lvalue reference of type ‘cvector&’ to an rvalue of type ‘cvector’
   return cvector(x1*x2.x, x1*x2.y, x1*x2.z); 
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

警告信息 #

class "cvector" has no suitable copy constructorC/C++(334)

原始cvector3D.h代码 #

# ifndef CVECTOR3D_H
# define CVECTOR3D_H

#include<cmath>
#include<ostream>
#include<iomanip>
using namespace std;

/*A three-dimensional real vector class is defined to facilitate numerical calculations*/
class cvector
{
public:
    double x, y, z;
    //Construct function
    cvector(double _x, double _y, double _z){ x = _x; y = _y; z = _z; } 
    //Copy the constructor
    cvector(cvector &pt){ x = pt.x; y = pt.y; z = pt.z; }
    cvector(){ x = 0; y = 0; z = 0; }
    ~cvector(){};

    //Operator overloading
    cvector operator +();
    cvector operator -();                   //The vector is negated

    friend  ostream  &operator<<(ostream &os, const cvector &x1);

    cvector operator +(cvector x1);
    cvector operator -(cvector x1);
    cvector operator *(double x1);
    cvector operator /(double x1);
    cvector &operator =(cvector x1);
    cvector &operator +=(cvector x1);
    cvector &operator -=(cvector x1);
    cvector &operator *=(double x1);
    cvector &operator /=(double x1);
    int operator ==(cvector x1);
    int operator !=(cvector x1);
    friend cvector operator *(double x1, cvector x2) {
        return cvector(x1*x2.x, x1*x2.y, x1*x2.z); 
    }
    //Member functions
    double  dist(cvector x1);                       
    cvector unit();                               
    double  norm();                           
    friend cvector cross(cvector x1, cvector x2)       
    {
        return cvector(x1.y*x2.z - x1.z*x2.y, x1.z*x2.x - x1.x*x2.z, x1.x*x2.y - x1.y*x2.x);
    }
    friend double dot(cvector x1, cvector x2)      
    {
        return (x1.x*x2.x + x1.y*x2.y + x1.z*x2.z);
    }
} ;

# endif

错误原因分析 #

1. 拷贝构造函数参数问题：自定义的拷贝构造函数cvector(cvector &pt)使用非const左值引用作为参数。当operator*(double, cvector)返回临时cvector对象时，这个临时对象是右值，C++不允许将非const左值引用绑定到右值，直接触发编译错误。同时编译器认为该拷贝构造函数不符合标准要求，因此抛出"无合适拷贝构造函数"的警告。
2. const缺失问题：大量成员函数（如operator+、operator-、dist等）的参数未使用const引用，不仅会导致不必要的对象拷贝，也不符合C++的const正确性原则，还可能间接引发其他绑定问题。

修改方案 #

1. 修正拷贝构造函数 #

将拷贝构造函数的参数改为const cvector &pt，使其既能绑定左值，也能绑定临时右值：

cvector(const cvector &pt){ x = pt.x; y = pt.y; z = pt.z; }

2. 优化成员函数参数（const引用） #

所有不需要修改传入对象的成员函数，参数都改为const cvector &，减少拷贝并符合const正确性：

• operator+、operator-、operator==、operator!=、dist
• 友元函数cross、dot、operator*(double, cvector)的参数也改为const cvector &

3. 修正赋值运算符参数（可选优化） #

赋值运算符operator=的参数建议改为const cvector &，避免不必要的拷贝：

cvector &operator =(const cvector &x1);

修改后的完整代码 #

# ifndef CVECTOR3D_H
# define CVECTOR3D_H

#include<cmath>
#include<ostream>
#include<iomanip>
using namespace std;

/*三维实向量类，用于数值计算*/
class cvector
{
public:
    double x, y, z;
    //构造函数
    cvector(double _x, double _y, double _z){ x = _x; y = _y; z = _z; } 
    //拷贝构造函数
    cvector(const cvector &pt){ x = pt.x; y = pt.y; z = pt.z; }
    //默认构造函数
    cvector(){ x = 0; y = 0; z = 0; }
    ~cvector(){};

    //运算符重载
    cvector operator +();
    cvector operator -();                   //向量取反

    friend  ostream  &operator<<(ostream &os, const cvector &x1);

    cvector operator +(const cvector &x1);
    cvector operator -(const cvector &x1);
    cvector operator *(double x1);
    cvector operator /(double x1);
    cvector &operator =(const cvector &x1);
    cvector &operator +=(const cvector &x1);
    cvector &operator -=(const cvector &x1);
    cvector &operator *=(double x1);
    cvector &operator /=(double x1);
    int operator ==(const cvector &x1);
    int operator !=(const cvector &x1);
    friend cvector operator *(double x1, const cvector &x2) {
        return cvector(x1*x2.x, x1*x2.y, x1*x2.z); 
    }
    //成员函数
    double  dist(const cvector &x1);                       
    cvector unit();                               
    double  norm();                           
    friend cvector cross(const cvector &x1, const cvector &x2)       
    {
        return cvector(x1.y*x2.z - x1.z*x2.y, x1.z*x2.x - x1.x*x2.z, x1.x*x2.y - x1.y*x2.x);
    }
    friend double dot(const cvector &x1, const cvector &x2)      
    {
        return (x1.x*x2.x + x1.y*x2.y + x1.z*x2.z);
    }
} ;

# endif

验证说明 #

修改后，operator*(double, cvector)返回的临时对象可以正常被拷贝构造函数接收，编译错误和警告都会消失。同时使用const引用参数减少了对象拷贝开销，提升了代码效率和健壮性。

内容的提问来源于stack exchange，提问作者ojipadeson