Node.js/MongoDB/Express下根据ID批量获取购物车商品失败问题求助

Hey there! Let's figure out why your fetchCart function isn't returning the expected cart items and get it working properly.

The Core Issues in Your Code #

Let's break down the problems first:

1. Asynchronous Timing Mismatch: Your for loop fires off multiple asynchronous findOne calls, but you immediately return the empty fetchedCart array before any of those database calls complete. The .then() callbacks run later, long after the function has already returned.
2. Typo: You wrote mogoDb.ObjectId instead of mongodb.ObjectId (missing an 'n' in "mongo").
3. Loop Variable Scope: Using var i in your loop can cause unexpected behavior with asynchronous callbacks, since var is function-scoped rather than block-scoped.

The Fixed Implementation #

Here's how to rewrite the function to handle asynchronous operations correctly, fix the typo, and improve variable scoping:

static async fetchCart(itemArr) {
  const userCart = [...itemArr];
  const db = getDb();
  // Create an array of Promises for each product fetch
  const fetchPromises = userCart.map(item => {
    return db.collection("products")
      .findOne({ _id: new mongodb.ObjectId(item.productId) })
      .catch(err => {
        console.error(`Failed to fetch product ${item.productId}:`, err);
        // Return null or a placeholder for failed fetches to avoid breaking Promise.all
        return null;
      });
  });

  // Wait for all Promises to resolve, then filter out any null/failed results
  const fetchedCart = await Promise.all(fetchPromises);
  return fetchedCart.filter(item => item !== null);
}

Key Improvements Explained #

• async/await + Promise.all: This lets us wait for all database calls to finish before returning the results. Promise.all takes an array of Promises and resolves when all of them are done, which is perfect for batch operations like this.
• map Instead of for Loop: Using map is cleaner for creating our array of Promises, and avoids the scope issues of var.
• Typo Fix: Corrected mogoDb to mongodb to properly reference the MongoDB ObjectId constructor.
• Error Handling: We added a .catch() to each individual fetch so that one failed product doesn't break the entire batch, and filter out any failed results at the end.

How to Use the Fixed Function #

Since this is now an async function, you'll need to use await or .then() when calling it:

// Using await (inside an async function)
const cartItems = await YourClass.fetchCart(yourItemArray);

// Or using .then()
YourClass.fetchCart(yourItemArray)
  .then(cartItems => {
    // Do something with your cart items
  })
  .catch(err => {
    // Handle any top-level errors
  });

内容的提问来源于stack exchange，提问作者Shakya Peiris