如何在C语言中找出三个输入数的最大值？代码错误排查求助

Hey there! Let's break down your code and fix the issues step by step to find the highest of three input numbers in C.

First, Let's Spot the Errors in Your Code #

Let's go through the problems one by one:

• Incorrect Conditional Logic
  Your if conditions like a<=b>=c don't behave as intended in C. In C, this expression is evaluated left to right: first a <= b returns 0 (false) or 1 (true), then that boolean result is compared to c using >=. This doesn't check if b is greater than or equal to both a and c—it's doing something totally unrelated! You need to use the logical AND operator (&&) to combine two separate conditions, like a <= b && b >= c.

• Typos in Print Statements
  In your last printf call, there's a typo: "higest number isd %d" should be "highest number is a %d" (you added an extra 'd' and missed a space before a). Also, "higest" is misspelled as "highest"—a small fix but makes the output clearer!

• Uncovered Edge Cases
  Your original conditions don't explicitly handle scenarios where two numbers are equal to the maximum (e.g., a = 5, b = 5, c = 3). While the fixed conditional logic will still catch these cases, we can structure the code more cleanly to avoid any ambiguity.

Fixed Version of Your Code #

Here's the corrected code with all the above issues addressed:

#include<stdio.h>
int main(){
    int a,b,c;
    printf("enter first number: ");
    scanf("%d",&a);
    printf("enter second number: ");
    scanf("%d",&b);
    printf("enter third number: ");
    scanf("%d",&c);
    
    if(a <= b && b >= c){
        printf("highest number is b: %d\n", b);
    } else if(b <= c && c >= a){
        printf("highest number is c: %d\n", c);
    } else if(c <= a && a >= b){
        printf("highest number is a: %d\n", a);
    }
    return 0;
}

A More Concise Alternative #

If you want a cleaner, more readable way to find the maximum, you can break it down step by step or use ternary operators:

#include<stdio.h>
int main(){
    int a,b,c, max;
    printf("enter first number: ");
    scanf("%d",&a);
    printf("enter second number: ");
    scanf("%d",&b);
    printf("enter third number: ");
    scanf("%d",&c);
    
    // First find the max of a and b, then compare with c
    max = (a > b) ? a : b;
    max = (max > c) ? max : c;
    
    printf("highest number is: %d\n", max);
    return 0;
}

This approach avoids messy conditional chains and naturally covers all edge cases, including when multiple numbers are equal to the maximum.

内容的提问来源于stack exchange，提问作者Prasant Mhrzn