WinForms中CheckedListBox勾选时动态生成/移除TextBox问题求助

我用C# WinForms创建了一个带多选项的CheckedListBox，需求是：勾选选项时实时生成对应的TextBox，取消勾选时移除对应TextBox。但当前代码勾选后没生成TextBox，求帮助。

原代码如下：

private void rangetypecheckedlistbox_ItemChecked(object sender, ItemCheckEventArgs e)
{
    List<string> checkedrangetypes = new List<string>();
    foreach (object item in ((CheckedListBox)panel_corebonusbonuses.Controls["comboBox_corebonusbonuses_range_type_input"]).CheckedItems)
    {
        checkedrangetypes.Add(item.ToString());
    }
    foreach (string item in checkedrangetypes)
    {
        Label newdynamicvallabel = new Label();
        newdynamicvallabel.Size = new Size(201, 20);
        newdynamicvallabel.Name = "dynamic_label" + item;
        newdynamicvallabel.Location = new Point(100, 130);
        newdynamicvallabel.Text = item.ToUpper() + " VALUE";

        //Create range_type textbox.
        TextBox newdynamicvaltext = new TextBox();
        newdynamicvaltext.Size = new Size(272, 28);
        newdynamicvaltext.Name = "dynamic_textbox_" + item + "_input";
        newdynamicvaltext.Location = new Point(381, 127);
        newdynamicvaltext.BorderStyle = BorderStyle.FixedSingle;

        panel_corebonusbonuses.Controls.Add(newdynamicvallabel);
        panel_corebonusbonuses.Controls.Add(newdynamicvaltext);

        checkedrangetypes.Remove(item);
    }
}

问题分析 #

1. 控件引用错误：你把CheckedListBox的Name写成了comboBox_corebonusbonuses_range_type_input（带comboBox前缀），但触发事件的控件是rangetypecheckedlistbox，控件查找失败导致无法获取勾选项。
2. 遍历集合时修改集合：foreach循环里调用checkedrangetypes.Remove(item)会直接抛出遍历异常，中断后续逻辑。
3. 未处理取消勾选逻辑：代码只做了添加控件，没有移除取消勾选项对应的Label和TextBox。
4. 控件位置重叠：所有新控件都固定在同一位置，就算创建成功也会重叠在一起无法看到。
5. 重复创建控件：每次勾选都会重新创建相同控件，导致控件重复添加。

修正后的代码 #

private void rangetypecheckedlistbox_ItemChecked(object sender, ItemCheckEventArgs e)
{
    // 获取当前触发事件的CheckedListBox实例，避免重复查找
    var checkedListBox = sender as CheckedListBox;
    if (checkedListBox == null) return;

    // 1. 收集当前所有已勾选的项
    var currentCheckedItems = checkedListBox.CheckedItems.Cast<string>().ToList();
    // 2. 收集面板中所有已存在的动态控件的关联项名称
    var existingDynamicItems = panel_corebonusbonuses.Controls
        .OfType<Label>()
        .Where(l => l.Name.StartsWith("dynamic_label"))
        .Select(l => l.Name.Replace("dynamic_label", ""))
        .ToList();

    // --- 移除取消勾选项对应的控件 ---
    foreach (var itemToRemove in existingDynamicItems.Except(currentCheckedItems))
    {
        // 查找对应的Label和TextBox并移除
        var label = panel_corebonusbonuses.Controls["dynamic_label" + itemToRemove];
        var textBox = panel_corebonusbonuses.Controls["dynamic_textbox_" + itemToRemove + "_input"];
        if (label != null) panel_corebonusbonuses.Controls.Remove(label);
        if (textBox != null) panel_corebonusbonuses.Controls.Remove(textBox);
    }

    // --- 为新增的勾选项创建控件（避免重复） ---
    // 计算控件起始位置和垂直间距，避免重叠
    int startY = 130;
    int verticalSpacing = 40;
    int currentIndex = 0;

    foreach (var item in currentCheckedItems)
    {
        // 如果控件已存在，跳过创建
        if (panel_corebonusbonuses.Controls.ContainsKey("dynamic_label" + item))
        {
            currentIndex++;
            continue;
        }

        // 创建Label
        Label newLabel = new Label();
        newLabel.Size = new Size(201, 20);
        newLabel.Name = "dynamic_label" + item;
        newLabel.Location = new Point(100, startY + currentIndex * verticalSpacing);
        newLabel.Text = item.ToUpper() + " VALUE";

        // 创建TextBox
        TextBox newTextBox = new TextBox();
        newTextBox.Size = new Size(272, 28);
        newTextBox.Name = "dynamic_textbox_" + item + "_input";
        newTextBox.Location = new Point(381, startY + currentIndex * verticalSpacing - 3);
        newTextBox.BorderStyle = BorderStyle.FixedSingle;

        // 添加到面板
        panel_corebonusbonuses.Controls.Add(newLabel);
        panel_corebonusbonuses.Controls.Add(newTextBox);

        currentIndex++;
    }
}

关键改进说明 #

• 直接通过sender获取CheckedListBox实例，避免控件名称写错的问题
• 先移除未勾选项对应的控件，再创建新增勾选项的控件，逻辑清晰
• 检查控件是否已存在，避免重复创建
• 用垂直间距动态计算控件位置，解决重叠问题
• 使用LINQ简化集合操作，代码更简洁

内容的提问来源于stack exchange，提问作者datacat