UISegmentedControl返回数据后分段重叠问题求助

Hey there! The root cause of your overlapping segmented controls is pretty straightforward: every time viewWillAppear runs, you're creating an entirely new UISegmentedControl, UIButton, and UIStackView, then adding them directly to your view without removing the old ones. Those original controls never get deleted, so they stack up underneath the new ones.

Let's fix this by separating your UI setup into two logical parts:

• One-time setup of fixed UI elements (like the stack view and "OK" button) that never change
• Dynamic updates for the segmented control, which is the only part that needs to adjust when your array updates

Modified ViewControllerA Code #

class VCA: UIViewController, Info {
    // 存储分段控件名称的数组
    var array = ["Peter", "Bob", "Jim"]
    var segmentedControl: UISegmentedControl!
    // 把stackView设为类属性，方便后续复用
    private var stackView: UIStackView!
    
    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)
        // 只更新分段控件的内容，不重建整个UI
        updateSegmentedControl(with: array)
    }
    
    override func viewDidLoad() {
        super.viewDidLoad()
        // 一次性初始化固定的UI结构
        setupFixedUI()
        // 初始化分段控件
        updateSegmentedControl(with: array)
    }
    
    // 代理协议：接收来自VCB的数据
    func passData(array: [String]) {
        self.array = array
        // 数据更新后立即刷新分段控件
        updateSegmentedControl(with: array)
    }
    
    // 初始化固定的UI元素（stackView和OK按钮）
    private func setupFixedUI() {
        let button = UIButton(type: .system)
        button.translatesAutoresizingMaskIntoConstraints = false
        button.setTitle("OK", for: .normal)
        button.addTarget(self, action: #selector(buttonTapped), for: .touchUpInside)
        
        stackView = UIStackView()
        stackView.axis = .vertical
        stackView.distribution = .fillEqually
        stackView.spacing = 50
        stackView.addArrangedSubview(button)
        
        view.addSubview(stackView)
        stackView.translatesAutoresizingMaskIntoConstraints = false
        
        NSLayoutConstraint.activate([
            stackView.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor, constant: 20),
            stackView.bottomAnchor.constraint(equalTo: view.safeAreaLayoutGuide.bottomAnchor, constant: -20),
            stackView.leadingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.leadingAnchor, constant: 20),
            stackView.trailingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.trailingAnchor, constant: -20)
        ])
    }
    
    // 专门用于更新分段控件的方法（更高效的复用方式）
    private func updateSegmentedControl(with items: [String]) {
        // 如果分段控件还没初始化，先创建
        if segmentedControl == nil {
            segmentedControl = UISegmentedControl(items: items)
            segmentedControl.translatesAutoresizingMaskIntoConstraints = false
            stackView.insertArrangedSubview(segmentedControl, at: 0)
        } else {
            // 清空旧分段，添加新内容
            segmentedControl.removeAllSegments()
            for (index, item) in items.enumerated() {
                segmentedControl.insertSegment(withTitle: item, at: index, animated: false)
            }
        }
        segmentedControl.selectedSegmentIndex = 0
    }
    
    @objc func buttonTapped() {
        let destinationVC = VCB()
        destinationVC.array = array
        destinationVC.infoDelegate = self
        destinationVC.modalPresentationStyle = .fullScreen
        present(destinationVC, animated: true, completion: nil)
    }
}

Key Changes Explained #

1. Separated Fixed & Dynamic UI: We now create the stack view and "OK" button only once in viewDidLoad—these elements never change, so there's no reason to recreate them every time the view appears.
2. Reusable Segmented Control: Instead of creating a brand new segmented control every time, we reuse the existing instance. We clear old segments and insert new ones, which is more efficient and avoids adding duplicate views to the hierarchy.
3. Tighter Data Flow: When we receive updated data from VCB via the delegate, we immediately refresh the segmented control, so changes take effect right away.

Why This Fixes the Overlap #

Previously, every call to your original setView method was adding a new stack view (with a new segmented control and button) directly on top of the old ones. Now, we only ever have one stack view in the view hierarchy, and we just update the segmented control inside it when needed.

Your ViewControllerB and Info protocol code don't need any changes—they're already working correctly to pass the updated array back to VCA.

内容的提问来源于stack exchange，提问作者swordse