Android Compose中Composable函数无限更新问题求助

我是Android开发新手，遇到了一个问题：我有一个包含var testQuestionsAmount by mutableStateOf(10) private set变量的ViewModel，在主界面使用正常，但将其作为导航参数传入GeneratedTestScreen后，该Composable函数会无限更新，导致从Room数据库无限生成试题。相关代码如下：

ViewModel变量 #

var testQuestionsAmount by mutableStateOf(10)
        private set

GeneratedTestScreen代码 #

//For some reason, this updates infinitely
@Composable
fun GeneratedTestScreen(questionsAmount: Int) {
    val context = LocalContext.current
    val questionRepository by lazy {
        QuestionRepository(QuestionDatabase.getInstance(context).dao)
    }
    val questionsList = questionRepository.getRandomQuestions(questionsAmount).collectAsState(initial = emptyList()).value
    val currentTestViewModel = viewModel<GeneratedTestScreenViewModel>(
        factory = object : ViewModelProvider.Factory {
            override fun <T : ViewModel> create(modelClass: Class<T>): T {
                return GeneratedTestScreenViewModel(questionsList = questionsList) as T
            }
        }
    )
    Log.d("AMOUNT", questionsAmount.toString())
}

NavGraph配置 #

composable(route = Screen.GeneratedTest.route, arguments = listOf(
    navArgument("questionsAmount") {
        type = NavType.IntType 
    }
)) {
    val questionsAmount = it.arguments?.getInt("questionsAmount")
        GeneratedTestScreen(questionsAmount ?: 1)
}

密封类定义 #

object GeneratedTest : Screen("GeneratedTest/{questionsAmount}", Icons.Rounded.List, "Test") {
        fun putQuestionsAmount(amount: Int): String {
            return "GeneratedTest/$amount"
        }
    }

跳转代码 #

@Composable
fun TestGenerationScreen(navController: NavController) {
    val viewModel = viewModel<TestGenerationScreenViewModel>()

    ...

        Column(
            verticalArrangement = Arrangement.Center,
            horizontalAlignment = Alignment.CenterHorizontally,
            modifier = Modifier
                .weight(1f)
                .fillMaxWidth()
        ) {
            Button(
                shape = RoundedCornerShape(dimensionResource(id = R.dimen.padding_small)),
                colors = ButtonDefaults.buttonColors(colorResource(id = R.color.approval_green)),
                // Navigation from main to GeneratedTestScreen
                onClick = { navController.navigate(Screen.GeneratedTest.putQuestionsAmount(viewModel.testQuestionsAmount)) },
                modifier = Modifier.align(Alignment.CenterHorizontally)
            ) {
                Text(text = stringResource(id = R.string.test_gen_screen_start_test_button_text))
            }
        }
    }
}

我已排查过Room查询语句无误，也了解到ViewModel在退栈后会留存内存，但当前两个页面均在回退栈中，此情况与问题无关。请问该问题的原因是什么？如何解决？

问题原因 #

• ViewModel创建逻辑不稳定：每次Composable重组时，都会创建新的匿名ViewModelProvider.Factory实例。Jetpack Compose会因为Factory实例变化，判定需要重新创建GeneratedTestScreenViewModel。
• Flow收集触发连锁重组：collectAsState会在Room返回新数据时触发Composable重组，而ViewModel的重新创建又会重新执行Flow查询，再次触发重组，形成无限循环。
• 匿名Factory的无状态性：匿名内部类每次重组都会生成全新实例，ViewModelProvider无法识别这是同一个ViewModel的创建请求，导致每次重组都生成新的ViewModel，进一步加剧循环。

解决办法 #

方案1：把Flow收集逻辑移到ViewModel（推荐） #

将Room查询和Flow处理放到ViewModel内部，利用stateIn转换为StateFlow，避免在Composable中直接处理数据逻辑：

1. 修改GeneratedTestScreenViewModel：

class GeneratedTestScreenViewModel(
    private val questionRepository: QuestionRepository,
    private val questionsAmount: Int
) : ViewModel() {
    // 用stateIn将Flow转换为StateFlow，在ViewModel层管理数据
    val questionsList = questionRepository.getRandomQuestions(questionsAmount)
        .stateIn(
            scope = viewModelScope,
            started = SharingStarted.WhileSubscribed(5000), // 订阅超时后停止收集，避免资源浪费
            initialValue = emptyList()
        )
}

2. 修改GeneratedTestScreen代码：

@Composable
fun GeneratedTestScreen(questionsAmount: Int) {
    val context = LocalContext.current
    // 用remember稳定Repository实例，避免每次重组创建新对象
    val questionRepository = remember {
        QuestionRepository(QuestionDatabase.getInstance(context).dao)
    }
    // 用remember包裹Factory，仅当依赖的参数变化时才重新创建
    val viewModelFactory = remember(questionRepository, questionsAmount) {
        object : ViewModelProvider.Factory {
            override fun <T : ViewModel> create(modelClass: Class<T>): T {
                return GeneratedTestScreenViewModel(questionRepository, questionsAmount) as T
            }
        }
    }
    val currentTestViewModel = viewModel<GeneratedTestScreenViewModel>(factory = viewModelFactory)
    // 收集ViewModel中的StateFlow
    val questionsList = currentTestViewModel.questionsList.collectAsState().value

    Log.d("AMOUNT", questionsAmount.toString())
}

方案2：用remember稳定Factory实例 #

如果必须在Composable中创建ViewModel，确保Factory实例稳定，避免每次重组都创建新对象：

@Composable
fun GeneratedTestScreen(questionsAmount: Int) {
    val context = LocalContext.current
    val questionRepository by lazy {
        QuestionRepository(QuestionDatabase.getInstance(context).dao)
    }
    // 用remember绑定Factory到questionsAmount和questionRepository，仅当参数变化时更新Factory
    val factory = remember(questionsAmount, questionRepository) {
        object : ViewModelProvider.Factory {
            override fun <T : ViewModel> create(modelClass: Class<T>): T {
                // 如果只需要一次性获取数据，用first()获取Flow的第一个值；若需监听变化，建议用方案1
                val questionsList = runBlocking {
                    questionRepository.getRandomQuestions(questionsAmount).first()
                }
                return GeneratedTestScreenViewModel(questionsList = questionsList) as T
            }
        }
    }
    val currentTestViewModel = viewModel<GeneratedTestScreenViewModel>(factory = factory)

    Log.d("AMOUNT", questionsAmount.toString())
}

关键注意事项 #

• 永远不要在Composable顶层创建不稳定对象（如匿名类、lambda），必须用remember或rememberSaveable保持实例稳定。
• 数据层的Flow收集逻辑尽量放在ViewModel中，Composable只负责UI渲染，减少不必要的重组触发。
• 导航参数questionsAmount是稳定的Int类型，本身不会引发无限重组，问题核心在于ViewModel创建逻辑的不稳定性。

内容的提问来源于stack exchange，提问作者Slizness