Java 11 Spring Boot微服务中清理大量if验证语句的优化建议咨询

Hey Steve, let's tackle this messy validation method together. I've been in exactly the same situation where monolithic validation logic turns into a maintenance nightmare, so here are some practical, actionable steps to clean this up:

First, break this giant method into smaller, focused methods—each handling one specific category of validation. This makes the code way easier to read, test, and modify later. No more scrolling through 50 lines of ifs to find a single rule!

For example:

public void validateRequest(DepositRequest depositRequest, String transferId, String userId) {
    validateTransferType(depositRequest, transferId, userId);
    validateGroupHeaderMandatoryFields(depositRequest, transferId, userId);
    validateTransferParties(depositRequest, transferId, userId);
    validateAuthorizationToken(depositRequest, transferId, userId);
    validateCreditorAccount(depositRequest, transferId, userId);
    validateSettlementDate(depositRequest, transferId, userId);
}

// Handles only transfer type validation
private void validateTransferType(DepositRequest depositRequest, String transferId, String userId) {
    final Set<String> VALID_TRANSFER_TYPES = Set.of("REALTIME_PAYMENT", "ACCOUNT_PAYMENT");
    String transferType = depositRequest.creditTransfer().getTransferInformation().getValue();
    
    if (!VALID_TRANSFER_TYPES.contains(transferType)) {
        logError(depositRequest, userId, transferId, INVALID_ACCOUNT_NUMBER);
        throw new ServerValidationException(INVALID_ACCOUNT_NUMBER, PAYMENT);
    }
}

// Handles all group header mandatory field checks
private void validateGroupHeaderMandatoryFields(DepositRequest depositRequest, String transferId, String userId) {
    CreditTransfer creditTransfer = depositRequest.creditTransfer();
    GroupHeader groupHeader = creditTransfer.getGroupHeader();

    if (groupHeader.getSettlementInformation().getClearingSystem() == null) {
        handleSchemaValidationError(depositRequest, transferId, userId, "proprietary");
    }
    if (groupHeader.getInstructing().getInstitutionIdentification().getMemberIdentification() == null) {
        handleSchemaValidationError(depositRequest, transferId, userId, "member_identification");
    }
    // Fix your typo here! I assume this was meant to be getInstructedFinancialInstitutionIdentification()
    if (groupHeader.getInstructedFinancialInstitutionIdentification().getMemberIdentification() == null) {
        handleSchemaValidationError(depositRequest, transferId, userId, "member_identification");
    }
}

Notice how you repeat the same log-and-throw pattern for most schema validation errors? Extract that into a helper method to cut down on boilerplate:

private void handleSchemaValidationError(DepositRequest depositRequest, String transferId, String userId, String field) {
    logSchemaValidationError(depositRequest, transferId, userId, field);
    throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
}

Now every null check just calls this one method instead of repeating 2 lines of code each time.

Since you're using Spring Boot, leverage Jakarta Bean Validation (JSR-380) to replace manual null checks and basic constraints. Annotate your DTO classes directly, and let Spring handle the validation heavy lifting.

For example, update your TransferInformation class:

public class TransferInformation {
    // Validate transfer type is one of the allowed values
    @Pattern(regexp = "REALTIME_PAYMENT|ACCOUNT_PAYMENT", message = "Invalid transfer type")
    private String value;

    @NotNull(message = "Creditor name cannot be null")
    private Creditor creditor;

    @NotNull(message = "Debtor name cannot be null")
    private Debtor debtor;

    // ... other fields
}

Then in your service method, add @Valid to trigger validation (or use a Validator bean manually):

import jakarta.validation.Valid;

public void validateRequest(@Valid DepositRequest depositRequest, String transferId, String userId) {
    // Now all basic null/format checks are handled by Bean Validation
    // You only need to keep custom business rules here:
    validateTransferType(depositRequest, transferId, userId); // Or let the @Pattern handle this
    validateCreditorAccount(depositRequest, transferId, userId);
    validateSettlementDate(depositRequest, transferId, userId);
}

For custom rules like the settlement date check or account validation, you can create custom @Constraint annotations to keep everything consistent.

All those chained method calls (depositRequest.creditTransfer().getGroupHeader()...) are not only hard to read but also risky (if any intermediate object is null, you'll get a NullPointerException). Use Optional to safely navigate nested properties, or extract intermediate objects to local variables:

// Using Optional for safe navigation
Optional.ofNullable(depositRequest.creditTransfer())
        .map(CreditTransfer::getGroupHeader)
        .map(GroupHeader::getSettlementInformation)
        .map(SettlementInformation::getClearingSystem)
        .orElseThrow(() -> {
            handleSchemaValidationError(depositRequest, transferId, userId, "proprietary");
            return null; // Unreachable, but needed for syntax
        });

// Or extract to local variables for readability
CreditTransfer creditTransfer = depositRequest.creditTransfer();
GroupHeader groupHeader = creditTransfer.getGroupHeader();
SettlementInformation settlementInfo = groupHeader.getSettlementInformation();

if (settlementInfo.getClearingSystem() == null) {
    handleSchemaValidationError(depositRequest, transferId, userId, "proprietary");
}

Now that you've split the method into smaller pieces, write unit tests for each validation method. This ensures you don't break existing rules when making changes, and makes it easy to add new validations later. For example:

@Test
void validateTransferType_invalidType_throwsException() {
    DepositRequest request = createTestRequestWithTransferType("INVALID_TYPE");
    
    assertThrows(ServerValidationException.class, 
        () -> validator.validateRequest(request, "test-transfer-id", "test-user-id"));
}

内容的提问来源于stack exchange，提问作者Steve B