PyQt6实现GUI循环等待用户输入时多线程报错，求解决方案

使用Python 3.9和PyQt6开发GUI程序，需求如下：

• 用户点击按钮后启动循环
• 循环内等待用户输入，用户提供输入后，运行使用该输入的第二个函数
• 函数完成后进入下一轮循环

尝试用PyQt多线程实现时，单次循环正常，但多次循环会崩溃，报错QThread: Destroyed while thread is still running。附上简化版代码，请教实现方式是否正确并求改进建议。

简化版代码：

from PyQt6.QtCore import *
from PyQt6.QtGui import *
from PyQt6 import QtWidgets
import time

# Step 1: Create a worker class
class MyWorker(QObject):

    wait_for_input = pyqtSignal()
    done = pyqtSignal()

    @pyqtSlot()
    def firstWork(self):
        print('Waiting for user input')
        self.wait_for_input.emit()

    @pyqtSlot()
    def secondWork(self):
        print('doing second work')
        time.sleep(2)
        print('second work done')
        self.done.emit()


class Window(QtWidgets.QWidget):
    def __init__(self, parent = None):
        super(Window, self).__init__()

        self.initUi()

    def initUi(self):
        layout = QtWidgets.QVBoxLayout()
        self.start_button = QtWidgets.QPushButton('Start')
        self.start_button.setEnabled(True)
        layout.addWidget(self.start_button)
        self.textBrowser = QtWidgets.QTextBrowser()
        layout.addWidget(self.textBrowser)
        self.lineEdit = QtWidgets.QLineEdit()
        self.lineEdit.setEnabled(False)
        layout.addWidget(self.lineEdit)
        self.button = QtWidgets.QPushButton('Set')
        self.button.setEnabled(False)
        layout.addWidget(self.button)
        self.label = QtWidgets.QLabel()
        self.label.setGeometry(QRect(20, 20, 211, 16))
        self.label.setText('Loop No:')
        layout.addWidget(self.label)
        self.loop_label = QtWidgets.QLabel()
        self.loop_label.setGeometry(QRect(20, 20, 211, 16))
        self.loop_label.setText('0')
        layout.addWidget(self.loop_label)
        
        self.setLayout(layout)
        self.show()

        self.start_button.clicked.connect(lambda: self.for_loop())

    @pyqtSlot()
    def enable_user_input(self):
        self.lineEdit.setEnabled(True)
        self.button.setEnabled(True)

    @pyqtSlot()    
    def done(self):
        self.textBrowser.append("DONE")

    def for_loop(self): 
        n = 1
        print('Loop No.', n)
        self.loop_label.setText(str(n))
        self.textBrowser.append("Running loop No."+ str(n))
        self.get_user_input()
        
        # for n in range(1,4,1): 
        #     print('Loop No.', n)
        #     self.loop_label.setText(str(n))
        #     self.textBrowser.append("Running loop No."+ str(n))
        #     self.get_user_input()

    def get_user_input(self):
        # Step 2: Create a QThread object
        self.thread = QThread()
        # Step 3: Create a worker object
        self.worker = MyWorker()
        # Step 4: Move worker to the thread
        self.worker.moveToThread(self.thread)
        self.textBrowser.append("Provide a list of numbers from 10 to 100 separated by commas:")
        # Step 5: Connect signals and slots
        # - Start the thread
        self.thread.started.connect(self.worker.firstWork)

        # - Thread waiting for user input
        self.worker.wait_for_input.connect(self.enable_user_input)
        # - User has provided input
        self.button.clicked.connect(self.user_input_provided)

        # - End the thread
        #   > Print DONE
        self.worker.done.connect(self.done)
        #   > Quit the thread
        self.worker.done.connect(self.thread.quit)
        #   > Delete the worker
        self.worker.done.connect(self.worker.deleteLater)
        #   > Delete the Thread
        self.thread.finished.connect(self.thread.deleteLater)

        # Step 6: Start the thread
        self.thread.start()    
    
    def user_input_provided(self):
        user_input = self.lineEdit.text()
        print('user_input:', user_input)
        self.textBrowser.append(user_input)
        self.lineEdit.clear()
        self.lineEdit.setEnabled(False)
        self.button.setEnabled(False)
        self.worker.secondWork()

if __name__ == "__main__":
    app = QtWidgets.QApplication([])
    w = Window()
    app.exec()

核心问题 #

1. 重复绑定信号冲突：每次调用get_user_input()都会重新绑定self.button.clicked信号，多次循环后同一按钮点击会触发多次处理逻辑，导致线程状态混乱。
2. 线程生命周期管理错误：多次循环时新的线程/Worker实例会覆盖旧的，而旧线程可能仍在运行未销毁，触发QThread: Destroyed while thread is still running错误。
3. 同步循环阻塞UI：直接在for_loop()中用for循环调用get_user_input()会阻塞主线程，导致界面卡顿无响应。

改进方案 #

1. 用状态变量管理循环进度：避免同步循环，改用实例变量记录当前循环次数，异步触发下一轮。
2. 一次性绑定信号：将按钮点击信号的绑定移到初始化方法中，避免重复绑定。
3. 安全管理线程生命周期：确保上一轮线程完全销毁后再启动下一轮，或每轮创建独立的线程/Worker实例。
4. 通过信号触发循环流转：在Worker的done信号中触发下一轮循环，实现异步流程控制。

修改后的代码 #

from PyQt6.QtCore import *
from PyQt6.QtGui import *
from PyQt6 import QtWidgets
import time

class MyWorker(QObject):
    wait_for_input = pyqtSignal()
    done = pyqtSignal()
    # 新增信号传递用户输入
    input_received = pyqtSignal(str)

    @pyqtSlot()
    def start_work(self):
        print('Waiting for user input')
        self.wait_for_input.emit()

    @pyqtSlot(str)
    def process_input(self, user_input):
        print(f'Processing input: {user_input}')
        # 模拟耗时业务逻辑
        time.sleep(2)
        print('Input processed')
        self.done.emit()


class Window(QtWidgets.QWidget):
    def __init__(self, parent=None):
        super().__init__(parent)
        self.current_loop = 0
        self.max_loops = 3  # 设置总循环次数
        self.thread = None
        self.worker = None
        self.initUi()

    def initUi(self):
        layout = QtWidgets.QVBoxLayout()
        
        self.start_button = QtWidgets.QPushButton('Start')
        layout.addWidget(self.start_button)
        
        self.textBrowser = QtWidgets.QTextBrowser()
        layout.addWidget(self.textBrowser)
        
        self.lineEdit = QtWidgets.QLineEdit()
        self.lineEdit.setEnabled(False)
        layout.addWidget(self.lineEdit)
        
        self.button = QtWidgets.QPushButton('Set')
        self.button.setEnabled(False)
        layout.addWidget(self.button)
        
        # 优化循环编号布局
        loop_layout = QtWidgets.QHBoxLayout()
        self.label = QtWidgets.QLabel('Loop No:')
        loop_layout.addWidget(self.label)
        self.loop_label = QtWidgets.QLabel('0')
        loop_layout.addWidget(self.loop_label)
        layout.addLayout(loop_layout)
        
        self.setLayout(layout)
        self.show()

        # 一次性绑定所有信号
        self.start_button.clicked.connect(self.start_loop)
        self.button.clicked.connect(self.on_input_provided)

    def start_loop(self):
        self.start_button.setEnabled(False)
        self.current_loop = 1
        self.next_loop()

    def next_loop(self):
        if self.current_loop > self.max_loops:
            self.textBrowser.append("All loops completed!")
            self.start_button.setEnabled(True)
            return
        
        self.loop_label.setText(str(self.current_loop))
        self.textBrowser.append(f"Running loop No.{self.current_loop}")
        self.setup_worker()

    def setup_worker(self):
        # 每轮循环创建独立的线程和Worker
        self.thread = QThread()
        self.worker = MyWorker()
        self.worker.moveToThread(self.thread)

        self.textBrowser.append("Provide a list of numbers from 10 to 100 separated by commas:")

        # 连接信号槽
        self.thread.started.connect(self.worker.start_work)
        self.worker.wait_for_input.connect(self.enable_input)
        self.worker.done.connect(self.on_worker_done)
        # 确保线程和Worker资源正确销毁
        self.worker.done.connect(self.thread.quit)
        self.thread.finished.connect(self.worker.deleteLater)
        self.thread.finished.connect(self.thread.deleteLater)

        self.thread.start()

    def enable_input(self):
        self.lineEdit.setEnabled(True)
        self.button.setEnabled(True)

    def on_input_provided(self):
        user_input = self.lineEdit.text().strip()
        if not user_input:
            self.textBrowser.append("Please enter valid input!")
            return
        
        self.textBrowser.append(f"Received input: {user_input}")
        self.lineEdit.clear()
        self.lineEdit.setEnabled(False)
        self.button.setEnabled(False)
        
        # 通过信号传递输入给Worker处理
        self.worker.input_received.connect(self.worker.process_input)
        self.worker.input_received.emit(user_input)

    def on_worker_done(self):
        self.textBrowser.append("Loop completed")
        self.current_loop += 1
        # 异步触发下一轮循环
        QTimer.singleShot(0, self.next_loop)

if __name__ == "__main__":
    app = QtWidgets.QApplication([])
    w = Window()
    app.exec()

关键改进说明 #

• 状态驱动循环：用current_loop和max_loops控制循环进度，通过next_loop()异步启动下一轮，避免阻塞主线程。
• 信号绑定优化：按钮点击信号仅绑定一次，消除重复触发的问题。
• 线程安全销毁：每轮循环创建独立的线程和Worker，通过finished信号确保资源被正确回收，避免线程未结束就被覆盖。
• 规范的输入传递：通过信号将用户输入传递给Worker处理，符合Qt线程间通信的规范，避免直接跨线程调用方法的风险。

内容的提问来源于stack exchange，提问作者Juliana Sánches-Posada