C# WPF静态ViewModel场景下Button Command无法执行求助

问题概述 #

开发C# WPF应用时遇到按钮绑定的SaveCommand点击后无任何响应，曾怀疑是ViewModel静态实例导致。另外发现若在CanExecuteSaveCommand中加入MessageBox，会在应用启动时直接弹出，但点击按钮时却不会触发该方法。

相关代码片段 #

XAML代码（精简版） #

<UserControl x:Class="Dossier_Registratie.Views.OverledeneView"
   xmlns = "http://schemas.microsoft.com/winfx/2006/xaml/presentation" 
   xmlns:x = "http://schemas.microsoft.com/winfx/2006/xaml" 
   xmlns:mc = "http://schemas.openxmlformats.org/markup-compatibility/2006" 
   xmlns:d = "http://schemas.microsoft.com/expression/blend/2008"
   xmlns:local="clr-namespace:Dossier_Registratie.ViewModels"
   mc:Ignorable = "d" 
   d:DesignHeight="696.96" d:DesignWidth="1190.257"
   DataContext="{x:Static local:OverledeneViewModel.Instance}">
<Button x:Name="lbl_SaveOverledene" Command="{Binding Path=SaveCommand}" Content="Volgende" Margin="1035,16,15,0" VerticalAlignment="Top" Height="31" Width="138.257" TabIndex="29" FontFamily="Arial" />
</UserControl>

ViewModel代码片段 #

public class OverledeneViewModel : ViewModelBase
{
    //->Commands
    public ICommand SaveCommand { get; }
    
    //Builder
    private OverledeneViewModel()
    {
        overledeneRepository = new OverledeneRepository();
        UitvaartLeider = new OverledeneUitvaartleiderModel();
        PersoonsGegevens = new OverledenePersoonsGegevensModel();
        OverlijdenInfo = new OverledeneOverlijdenInfoModel();
        SaveCommand = new ViewModelCommand(ExecuteSaveCommand, CanExecuteSaveCommand);
    }

    public static OverledeneViewModel Instance { get; } = new();

    private bool CanExecuteSaveCommand(object obj)
    {
        bool validData;
        if(string.IsNullOrWhiteSpace(AchternaamOverledene) 
            || string.IsNullOrWhiteSpace(VoornaamOverledene) 
            || string.IsNullOrWhiteSpace(GeboortedatumOverledene))
        {
            validData = false;
        }
        else
        {
            validData = true;
        }
        return validData;
    }

    private void ExecuteSaveCommand(object obj)
    {
        var AddUitvaartleider = overledeneRepository.AddUitvaartleider;
        var AddPersoonsGegevens = overledeneRepository.AddPersoonsGegevens;
        var AddOverlijdenInfo = overledeneRepository.AddOverlijdenInfo;

        if (AddUitvaartleider.ToString() != "InsertUitvaartleiderSucces")
            throw new Exception("Uitvaarleider insert has failed");

        if (AddPersoonsGegevens.ToString() != "InsertPersoonsGegevensSucces")
            throw new Exception("Persoonsgegevens insert has failed");

        if (AddOverlijdenInfo.ToString() != "InsertOverlijdenInfoSucces")
            throw new Exception("OverlijdenInfo insert has failed");
    }
}

ViewModelCommand代码 #

public class ViewModelCommand : ICommand
{
    //fields
    private readonly Action<object> _executeAction;
    private readonly Predicate<object> _canExecuteAction;

    //Constructor
    public ViewModelCommand(Action<object> executeAction)
    {
        _executeAction = executeAction;
        _canExecuteAction = null;
    }

    public ViewModelCommand(Action<object> executeAction, Predicate<object> canExecuteAction)
    {
        _executeAction = executeAction;
        _canExecuteAction = canExecuteAction;
    }

    //Events
    public event EventHandler CanExecuteChanged
    {
        add { CommandManager.RequerySuggested += value;  }
        remove {  CommandManager.RequerySuggested -= value;}
    }

    //Methods
    public bool CanExecute(object parameter)
    {
        return _canExecuteAction == null ? true : _canExecuteAction(parameter);
    }

    public void Execute(object parameter)
    {
        _executeAction(parameter);
    }
}

问题根源分析 #

1. 按钮默认禁用：应用启动时，AchternaamOverledene、VoornaamOverledene、GeboortedatumOverledene均为空值，CanExecuteSaveCommand返回false，WPF会自动禁用按钮，导致点击无响应。
2. 属性变化未触发状态更新：即使后续输入了属性值，若ViewModel中这些属性未实现INotifyPropertyChanged通知，CommandManager不会自动重新调用CanExecuteSaveCommand，按钮会一直保持禁用状态。
3. 启动时触发CanExecute的原因：CommandManager.RequerySuggested事件在应用启动阶段会自动触发，因此CanExecuteSaveCommand会被调用，导致加入的MessageBox弹出；而按钮禁用后，点击操作不会触发CanExecute或Execute。

解决方案 #

1. 实现属性的通知机制 #

ViewModel中的AchternaamOverledene等属性必须在值变化时触发PropertyChanged事件，确保CommandManager能感知状态变化并重新判断CanExecute结果。示例实现：

private string _achternaamOverledene;
public string AchternaamOverledene
{
    get => _achternaamOverledene;
    set
    {
        if (_achternaamOverledene != value)
        {
            _achternaamOverledene = value;
            OnPropertyChanged(); // 需确保ViewModelBase正确实现该方法
        }
    }
}

同理完成VoornaamOverledene和GeboortedatumOverledene的属性实现。

2. 手动强制刷新Command状态 #

若某些场景下PropertyChanged无法自动触发更新，可在属性setter中手动调用：

CommandManager.InvalidateRequerySuggested();

强制所有Command重新查询CanExecute状态。

3. 验证ViewModelBase的实现 #

确保ViewModelBase正确实现INotifyPropertyChanged接口，示例：

public class ViewModelBase : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler PropertyChanged;

    protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
    }
}

4. 澄清静态实例的误解 #

单例模式（静态实例）本身不会导致Command绑定失效，只要ViewModel的属性通知机制正常，静态实例可以正常工作。

内容的提问来源于stack exchange，提问作者PatrickStel