如何拆分字符串提取首字符生成SamAccountName，冲突时生成可用用户名？

需求说明 #

给定名字（如John-Aron）和姓氏（如Albert）两个参数：

• 按空格或横杠拆分字符串，提取每个子串的首字符构建初始用户名（示例中为JAA）
• 通过DirectorySearcher在Active Directory中检查该samaccountname是否已存在
• 若已存在，从名字或姓氏中提取后续字符生成新的可用用户名

现有代码问题 #

用户已实现初始用户名生成及AD存在性检查，但未处理用户名冲突时的生成逻辑，以下为现有代码：

第一段代码（未完成的实现） #

public static string UsernameGeneration(string firstname, string lastname)
{
    string[] firstnames =null;
    string[] lastnames = null;

    string firstnamepart1 ="";
    string lastnamepart1 ="";

    if(firstname.Contains(" ") || firstname.Contains("-"))
    {
        if(firstname.Contains(" ")){
            firstnames = firstname.Split(" ".ToCharArray(),StringSplitOptions.RemoveEmptyEntries);
        }
        if(firstname.Contains("-")){
            firstnames = firstname.Split("-".ToCharArray(),StringSplitOptions.RemoveEmptyEntries);
        }
    }
    if(lastname.Contains(" ") || lastname.Contains("-"))
    {
        if(lastname.Contains(" ")){
            lastnames = lastname.Split(" ".ToCharArray(),StringSplitOptions.RemoveEmptyEntries);
        }
        if(lastname.Contains("-")){
            lastnames = lastname.Split("-".ToCharArray(),StringSplitOptions.RemoveEmptyEntries);
        }
    }

    char[] chars1 = firstnames[0].ToCharArray() + firstnames[1].ToCharArray();
    char[] chars2 = lastnames[0].ToCharArray() + lastnames[0].ToCharArray(); 

    StringBuilder result = new StringBuilder();

    for(int i = 1; i <=99; i++)
    {

        result.Append(chars1[]);
    }

    
    return "";
}

第二段代码（初始生成及检查） #

public static string UserNameGeneration(string firstname, string lastname)
{
    string firstNameChars = string.Join("", firstname.Split(new char[] { ' ', '-' }, StringSplitOptions.RemoveEmptyEntries).Select(x => x.First()));
    string lastNameChars = string.Join("", lastname.Split(new char[] { ' ', '-' }, StringSplitOptions.RemoveEmptyEntries).Select(x => x.First()));
    string tempUserName = string.Join("", firstNameChars , lastNameChars);

    using(System.DirectoryServices.DirectorySearcher searcher = new System.DirectoryServices.DirectorySearcher("(samaccountname="+tempUserName+")"))
    {
        if(searcher.FindAll().Count == 0)
            {
                return tempUserName;
            }
    }

    return "";
}

解决方案 #

以下是完善后的代码，包含冲突处理逻辑，采用先尝试初始用户名→数字后缀→扩展名字/姓氏字符的优先级策略：

using System;
using System.Linq;
using System.DirectoryServices;

public static class UsernameGenerator
{
    // 检查用户名在AD中是否存在
    private static bool IsUsernameExists(string username)
    {
        // 使用更高效的FindOne，找到匹配即停止
        using (var searcher = new DirectorySearcher($"(&(objectClass=user)(samaccountname={username}))"))
        {
            return searcher.FindOne() != null;
        }
    }

    // 生成初始用户名（提取各部分首字符）
    private static string GenerateInitialUsername(string firstname, string lastname)
    {
        var firstNameParts = firstname.Split(new[] { ' ', '-' }, StringSplitOptions.RemoveEmptyEntries);
        var lastNameParts = lastname.Split(new[] { ' ', '-' }, StringSplitOptions.RemoveEmptyEntries);
        
        string firstNameChars = string.Join("", firstNameParts.Select(p => p.First()));
        string lastNameChars = string.Join("", lastNameParts.Select(p => p.First()));
        
        return $"{firstNameChars}{lastNameChars}";
    }

    public static string UserNameGeneration(string firstname, string lastname)
    {
        if (string.IsNullOrWhiteSpace(firstname) || string.IsNullOrWhiteSpace(lastname))
        {
            throw new ArgumentException("名字和姓氏不能为空");
        }

        string initialUsername = GenerateInitialUsername(firstname, lastname);
        
        // 优先使用初始用户名
        if (!IsUsernameExists(initialUsername))
        {
            return initialUsername;
        }

        // 策略1：尝试添加1-99的数字后缀
        for (int i = 1; i <= 99; i++)
        {
            string candidate = $"{initialUsername}{i}";
            if (!IsUsernameExists(candidate))
            {
                return candidate;
            }
        }

        // 策略2：扩展名字的字符长度，结合姓氏首字符/完整姓氏
        var firstNameParts = firstname.Split(new[] { ' ', '-' }, StringSplitOptions.RemoveEmptyEntries);
        var lastNameParts = lastname.Split(new[] { ' ', '-' }, StringSplitOptions.RemoveEmptyEntries);
        string lastNameInitials = string.Join("", lastNameParts.Select(p => p.First()));
        string fullLastName = string.Join("", lastNameParts);

        foreach (var namePart in firstNameParts)
        {
            for (int len = 2; len <= namePart.Length; len++)
            {
                string nameSegment = namePart.Substring(0, len);
                // 名字片段+姓氏首字符
                string candidate = $"{nameSegment}{lastNameInitials}";
                if (!IsUsernameExists(candidate))
                {
                    return candidate;
                }
                // 名字片段+完整姓氏
                candidate = $"{nameSegment}{fullLastName}";
                if (!IsUsernameExists(candidate))
                {
                    return candidate;
                }
            }
        }

        // 策略3：扩展姓氏的字符长度，结合名字首字符/完整名字
        string firstNameInitials = string.Join("", firstNameParts.Select(p => p.First()));
        string fullFirstName = string.Join("", firstNameParts);

        foreach (var namePart in lastNameParts)
        {
            for (int len = 2; len <= namePart.Length; len++)
            {
                string nameSegment = namePart.Substring(0, len);
                // 名字首字符+姓氏片段
                string candidate = $"{firstNameInitials}{nameSegment}";
                if (!IsUsernameExists(candidate))
                {
                    return candidate;
                }
                // 完整名字+姓氏片段
                candidate = $"{fullFirstName}{nameSegment}";
                if (!IsUsernameExists(candidate))
                {
                    return candidate;
                }
            }
        }

        // 所有策略都尝试失败，抛出异常或返回空（根据业务需求调整）
        throw new InvalidOperationException("无法生成可用的AD用户名");
    }
}

代码说明 #

1. 封装检查方法：IsUsernameExists使用FindOne替代FindAll().Count，提升查询效率
2. 初始用户名生成：复用用户第二段代码的简洁逻辑，处理多部分名字/姓氏的拆分
3. 冲突处理策略：
   • 优先返回可用的初始用户名
   • 初始名被占用时，依次尝试添加数字后缀（1-99）
   • 数字后缀也被占用时，逐步扩展名字/姓氏的字符长度，生成候选用户名
4. 异常处理：添加空值检查，避免无效输入；所有候选都被占用时抛出异常，便于业务层处理

内容的提问来源于stack exchange，提问作者marius