XML转JSON工具：OpenFile函数无法关联Convert & Save函数问题

核心问题分析 #

1. openfile生成的JSON数据没有持久存储，「转换并保存」按钮无法获取到转换结果
2. savefile函数定义了参数但调用时未传值，且文件操作逻辑错误
3. 未处理用户取消文件选择的场景，会触发异常

修复后的完整代码 #

import tkinter as tk
import json
import xmltodict
from tkinter import messagebox
from tkinter import filedialog

# General setup
window = tk.Tk()
window.title("Convert XML to JSON")
window.geometry("500x500")
window.configure(bg="#333333")

# 全局变量存储转换后的JSON数据
converted_json = None

# Open File
def openfile():
    global converted_json
    path = filedialog.askopenfilename(title="Select a File", filetypes=[("xml files", "*.xml")])
    # 处理用户取消选择文件的情况
    if not path:
        return
    with open(path, "r", encoding='utf-8') as f_xml:
        f_read = f_xml.read()
    
    # convert xml to json
    parsed_data = xmltodict.parse(f_read, process_namespaces=False)
    converted_json = json.dumps(parsed_data, indent=4)
    
# save file
def savefile():
    global converted_json
    # 先检查是否已经转换过XML文件
    if not converted_json:
        messagebox.showwarning("提示", "请先选择并转换XML文件")
        return
    file = filedialog.asksaveasfile(mode='w', filetypes=[("json files", "*.json")], defaultextension=".json")
    # 处理用户取消保存的情况
    if not file:
        return
    file.write(converted_json)
    file.close()
    messagebox.showinfo("成功", "JSON文件已保存")

# Frame
frame = tk.Frame(bg="#333333")

# label and Button
title_label = tk.Label(frame, text="XML TO JSON Converter", bg="#3FFFFF", fg="#FF3389", font=("Arial", 30))
xml_label = tk.Label(frame, text="XML file input", bg="#3FFFFF", fg="#FF3399", font=("Arial", 15))
button_xml_label = tk.Button(frame, text="Browse", command=openfile, font=("Arial", 15))
JSON_label = tk.Label(frame, text="JSON file output", bg="#3FFFFF", fg="#FF3399", font=("Arial", 15))
button_save_label = tk.Button(frame, text="Convert & Save", command=savefile, font=("Arial", 15))

# Placing widgets on the screen
title_label.grid(row=0, column=0, columnspan=5, sticky="news", pady=40)
xml_label.grid(row=1, column=0, padx=5)
button_xml_label.grid(row=1, column=1, columnspan=3, padx=10, pady=20)
JSON_label.grid(row=2, column=0)
button_save_label.grid(row=2, column=1, columnspan=5, pady=20)

frame.pack()
window.mainloop()

关键修改说明 #

• 全局变量共享数据：新增converted_json全局变量，让openfile和savefile能共享转换后的JSON内容
• 异常场景处理：添加用户取消选择文件、取消保存操作的判断，避免程序崩溃；同时在未选择XML文件时点击保存，弹出提示
• 文件操作优化：使用with语句自动管理XML文件的打开/关闭；asksaveasfile直接返回可写入的文件对象，无需再次调用open
• 简化按钮绑定：去掉不必要的lambda表达式，直接绑定函数名

内容的提问来源于stack exchange，提问作者Sir Skywalker