MultiPage多页面下单个删除按钮对4个ListBox无响应的VBA问题

我写了一段VBA代码，想通过单个删除按钮删除MultiPage控件4个页面中对应ListBox的选中项，但点击按钮后毫无反应，也没弹出报错，找不到问题出在哪。原代码如下：

Private Sub cmdDelete_Click()
    Dim i As Long
    Dim selectedRows() As Long
    Dim count As Long
    Dim currentListBox As MSForms.listBox
    Dim currentPage As Long

    ' Determine the active ListBox on the current page
    currentPage = MultiPage1.Value

    ' Identify the active ListBox based on the current page
    Select Case currentPage
        Case 0
            Set currentListBox = ListBox1
        Case 1
            Set currentListBox = ListBox2
        Case 2
            Set currentListBox = ListBox3
        Case 3
            Set currentListBox = ListBox4
        Case Else
            ' Handle any other cases if needed
    End Select

    ' Check if a ListBox was identified
    If currentListBox Is Nothing Then
        MsgBox "Please ensure a ListBox is selected.", vbExclamation
        Exit Sub
    End If

    ' Determine the selected rows in the identified ListBox
    count = 0
    For i = 0 To currentListBox.ListCount - 1
        If currentListBox.Selected(i) Then
            ReDim Preserve selectedRows(count)
            selectedRows(count) = i
            count = count + 1
        End If
    Next i

    ' Delete the selected rows in reverse order
    For i = UBound(selectedRows) To LBound(selectedRows) Step -1
        ' Use the current ListBox's Tag property to determine which ListBox to delete from
        Select Case currentListBox.Tag
            Case "1"
                ' Delete rows from ListBox1 on Page 1
                MultiPage1.Pages(0).ListBox1.RemoveItem selectedRows(i)
            Case "2"
                ' Delete rows from ListBox2 on Page 2
                MultiPage1.Pages(1).ListBox2.RemoveItem selectedRows(i)
            Case "3"
                ' Delete rows from ListBox3 on Page 3
                MultiPage1.Pages(2).ListBox3.RemoveItem selectedRows(i)
            Case "4"
                ' Delete rows from ListBox4 on Page 4
                MultiPage1.Pages(3).ListBox4.RemoveItem selectedRows(i)
        End Select
    Next i
End Sub 

问题分析 #

1. Tag属性未配置：代码里靠currentListBox.Tag判断要操作的ListBox，但如果没给四个ListBox分别设置Tag属性（对应"1"、"2"、"3"、"4"），这部分Select Case不会触发任何删除操作，按钮自然没反应。
2. 冗余的ListBox引用：已经通过currentPage获取了当前页面的currentListBox对象，没必要再绕一圈用Tag和MultiPage.Pages去引用，完全是多余操作。
3. 无选中项时的数组越界隐患：如果没有选中任何项，selectedRows数组是空的，执行UBound(selectedRows)会直接报错，但你没看到报错，大概率是因为前面的Tag问题导致没走到这一步。

修复后的代码 #

Private Sub cmdDelete_Click()
    Dim i As Long
    Dim selectedRows() As Long
    Dim count As Long
    Dim currentListBox As MSForms.ListBox
    Dim currentPage As Long

    ' 获取当前页面索引
    currentPage = MultiPage1.Value

    ' 绑定当前页面的ListBox
    Select Case currentPage
        Case 0
            Set currentListBox = ListBox1
        Case 1
            Set currentListBox = ListBox2
        Case 2
            Set currentListBox = ListBox3
        Case 3
            Set currentListBox = ListBox4
        Case Else
            MsgBox "无效页面", vbExclamation
            Exit Sub
    End Select

    ' 检查是否获取到ListBox
    If currentListBox Is Nothing Then
        MsgBox "未找到对应ListBox", vbExclamation
        Exit Sub
    End If

    ' 收集选中行索引
    count = 0
    For i = 0 To currentListBox.ListCount - 1
        If currentListBox.Selected(i) Then
            ReDim Preserve selectedRows(count)
            selectedRows(count) = i
            count = count + 1
        End If
    Next i

    ' 无选中项时提示并退出
    If count = 0 Then
        MsgBox "请先选中要删除的项", vbInformation
        Exit Sub
    End If

    ' 倒序删除选中项（避免索引错乱）
    For i = UBound(selectedRows) To LBound(selectedRows) Step -1
        currentListBox.RemoveItem selectedRows(i)
    Next i
End Sub

修改说明 #

• 去掉了依赖Tag属性的冗余逻辑，直接用已获取的currentListBox执行删除操作，逻辑更简洁可靠。
• 添加了无选中项的判断，避免数组越界错误，同时给用户明确提示。
• 优化了错误提示的中文表述，更贴合使用场景。

内容的提问来源于stack exchange，提问作者Khai