Java Accounts类登录方法调用问题及代码修复咨询

核心问题梳理 #

• 直接调用account_list.log_in(scanner)错误：List<Accounts>没有log_in方法，这是触发报错的直接原因
• 实例方法调用逻辑错误：log_in是Accounts实例方法，原本逻辑是让单个账户验证自身信息，但实际登录场景是输入账号密码后，遍历账户列表匹配对应账户
• 字符串比较用==会导致引用地址对比，而非内容对比
• 硬编码账户ID为"1"会导致所有账户ID重复
• 拼写错误：sucscefully → successfully

修正后的完整代码 #

Accounts.java #

import java.util.Scanner;

public class Accounts {
    private String username;
    private String password;
    private boolean loggedIn; // 用基本类型避免空指针风险
    private String accountId;

    // 私有构造方法，仅通过createAccount创建实例
    private Accounts(String username, String password, boolean loggedIn, String accountId) {
        this.username = username;
        this.password = password;
        this.loggedIn = loggedIn;
        this.accountId = accountId;
    }

    // 静态计数器生成唯一账户ID
    private static int accountCounter = 1;
    public static Accounts createAccount(Scanner scanner) {
        System.out.println("Username:");
        String username = scanner.nextLine();
        System.out.println("Password:");
        String password = scanner.nextLine();
        String accountId = String.valueOf(accountCounter++);
        return new Accounts(username, password, false, accountId);
    }

    // 登录验证：直接接收输入的用户名密码，避免重复读取
    public boolean login(String inputUsername, String inputPassword) {
        if (inputUsername.equals(this.username) && inputPassword.equals(this.password)) {
            System.out.println("Logged in successfully!");
            this.loggedIn = true;
            return true;
        } else {
            System.out.println("Log in failed!");
            return false;
        }
    }

    // 登出方法
    public void logout() {
        this.loggedIn = false;
        System.out.println("Logged out successfully!");
    }

    // 状态与属性获取方法
    public boolean isLoggedIn() {
        return loggedIn;
    }

    public String getUsername() {
        return username;
    }

    @Override
    public String toString() {
        return "Account ID: %s, Username: %s".formatted(accountId, username);
    }
}

Project.java #

import java.util.ArrayList;
import java.util.List;
import java.util.Scanner;

public class Project {
    public static void main(String[] args) {
        List<Accounts> accountList = new ArrayList<>();
        Accounts currentLoggedInAccount = null; // 记录当前登录账户，避免多登录冲突

        try (Scanner scanner = new Scanner(System.in)) {
            System.out.println("Welcome to my password database program");
            boolean done = false;
            while (!done) {
                // 打印操作菜单
                System.out.println("""
                        1. Create account
                        2. Log in
                        3. View account info
                        4. Log out
                        5. Exit program
                        """);
                String choice = scanner.nextLine();

                switch (choice) {
                    case "1":
                        Accounts newAccount = Accounts.createAccount(scanner);
                        accountList.add(newAccount);
                        System.out.println("Created account: " + newAccount);
                        break;
                    case "2":
                        if (currentLoggedInAccount != null) {
                            System.out.println("You are already logged in as " + currentLoggedInAccount.getUsername());
                            break;
                        }
                        // 获取用户输入的登录信息
                        System.out.println("Enter username:");
                        String inputUsername = scanner.nextLine();
                        System.out.println("Enter password:");
                        String inputPassword = scanner.nextLine();

                        // 遍历账户列表匹配登录信息
                        boolean loginSuccess = false;
                        for (Accounts account : accountList) {
                            if (account.getUsername().equals(inputUsername)) {
                                loginSuccess = account.login(inputUsername, inputPassword);
                                if (loginSuccess) {
                                    currentLoggedInAccount = account;
                                }
                                break;
                            }
                        }
                        if (!loginSuccess) {
                            System.out.println("Account not found or password incorrect");
                        }
                        break;
                    case "3":
                        if (currentLoggedInAccount == null) {
                            System.out.println("Please log in first!");
                            break;
                        }
                        System.out.println("Your account details: " + currentLoggedInAccount);
                        break;
                    case "4":
                        if (currentLoggedInAccount == null) {
                            System.out.println("You are not logged in!");
                            break;
                        }
                        currentLoggedInAccount.logout();
                        currentLoggedInAccount = null;
                        break;
                    case "5":
                        done = true;
                        System.out.println("Exiting program...");
                        break;
                    default:
                        System.out.println("Invalid choice, try again");
                }
            }
        }
    }
}

关键修改说明 #

1. 修复集合调用错误：不再尝试调用列表的log_in方法，改为遍历账户列表，根据输入的用户名定位目标账户后调用实例登录方法
2. 字符串比较修正：用equals方法替换==，确保对比字符串内容而非引用地址
3. 登录逻辑优化：
   • 新增currentLoggedInAccount变量，管理当前登录状态，避免多账户同时登录的冲突
   • 修改login方法为直接接收用户名密码参数，避免重复读取输入
4. 账户ID优化：用静态计数器生成唯一ID，解决重复问题
5. 代码规范调整：
   • 采用Java驼峰命名法：account_list→accountList，log_in→login
   • 用基本类型boolean代替包装类Boolean，规避空指针风险
   • 修正拼写错误，补充必要的状态管理方法

内容的提问来源于stack exchange，提问作者user22866828