SwiftUI中“视图更新内发布变更”警告的排查与修复求助

问题根源 #

你的警告来自两个关键问题：

1. Core Data线程违规：Firebase的回调运行在后台线程，你直接在该线程访问主队列绑定的Core Data上下文（@Environment(\.managedObjectContext)默认是主队列上下文），违反了Core Data线程规则，同时导致状态更新时机混乱。
2. 状态更新时机错误：createOrUpdateChatEntities方法中，retrieveChatContacts在主队列异步块外部调用，导致它可能在SwiftUI视图更新周期内触发@Published状态变更，触发警告。

修复方案 #

1. 强制Core Data操作在正确队列执行 #

用context.perform替代手动DispatchQueue.main.async，Core Data会自动确保操作在上下文绑定的队列执行，彻底避免线程冲突。

2. 调整状态更新触发时机 #

把retrieveChatContacts的调用移到Core Data保存完成后的代码块里，确保只有当数据持久化完成后，才更新UI状态。

3. 修正Firebase回调的线程切换 #

Firebase的observe(.value)回调运行在后台线程，必须切换到Core Data上下文队列再执行后续操作。

修复后的完整代码 #

ChatsViewModel.swift #

import SwiftUI
import CoreData
import Firebase
import Combine

class ChatsViewModel: ObservableObject {
    @Published var chatContacts: [ChatEntity] = []
    private var ref = Database.database().reference()
    private var context: NSManagedObjectContext
    @Published var showOfflineAlert = false
    
    init(context: NSManagedObjectContext) {
        self.context = context
    }
    
    func fetchChatContacts() {
        if NetworkChecker.shared.isConnected {
            fetchFromFirebase()
        } else {
            DispatchQueue.main.async {
                self.showOfflineAlert = true
            }
            fetchFromCoreData()
        }
    }

    private func fetchFromFirebase() {
        guard let currentUserId = Auth.auth().currentUser?.uid else { return }
        let chatsRef = ref.child("Users/\(currentUserId)/Chats")
        chatsRef.observe(.value) { [weak self] snapshot in
            guard let self = self else { return }
            let contactIds = snapshot.children.compactMap { ($0 as? DataSnapshot)?.key }
            // 切换到Core Data上下文队列执行后续操作
            self.context.perform {
                self.matchContactsWithCoreData(contactIds: contactIds)
            }
        }
    }
    
    private func fetchFromCoreData() {
        context.perform { [weak self] in
            guard let self = self else { return }
            let fetchRequest: NSFetchRequest<ChatEntity> = ChatEntity.fetchRequest()
            fetchRequest.predicate = NSPredicate(format: "hasMessages == %@", NSNumber(value: true))
            do {
                let contacts = try self.context.fetch(fetchRequest)
                DispatchQueue.main.async {
                    self.chatContacts = contacts
                }
            } catch {
                print("Error fetching chat contacts from Core Data: \(error)")
            }
        }
    }

    private func matchContactsWithCoreData(contactIds: [String]) {
        let fetchRequest: NSFetchRequest<ContactEntity> = ContactEntity.fetchRequest()
        fetchRequest.predicate = NSPredicate(format: "contactId IN %@", contactIds)
        do {
            let matchedContacts = try context.fetch(fetchRequest)
            createOrUpdateChatEntities(from: matchedContacts)
        } catch {
            print("Error matching contacts in Core Data: \(error)")
        }
    }

    private func createOrUpdateChatEntities(from contacts: [ContactEntity]) {
        for contact in contacts {
            let fetchRequest: NSFetchRequest<ChatEntity> = ChatEntity.fetchRequest()
            fetchRequest.predicate = NSPredicate(format: "contactId == %@", contact.contactId ?? "")
            do {
                let existingChatEntities = try context.fetch(fetchRequest)
                let chatEntity: ChatEntity = existingChatEntities.first ?? ChatEntity(context: context)
                chatEntity.contactId = contact.contactId
                chatEntity.hasMessages = true
                chatEntity.givenName = contact.givenName
                chatEntity.familyName = contact.familyName
                chatEntity.avatarData = contact.avatarData
            } catch {
                print("Error fetching/updating chat entity: \(error)")
            }
        }
        do {
            try context.save()
            // 保存完成后再触发UI状态更新
            retrieveChatContacts()
        } catch {
            print("Error saving updated chat entities: \(error)")
        }
    }

    private func retrieveChatContacts() {
        context.perform { [weak self] in
            guard let self = self else { return }
            let fetchRequest: NSFetchRequest<ChatEntity> = ChatEntity.fetchRequest()
            fetchRequest.predicate = NSPredicate(format: "hasMessages == %@", NSNumber(value: true))
            do {
                let contacts = try self.context.fetch(fetchRequest)
                DispatchQueue.main.async {
                    self.chatContacts = contacts
                }
            } catch {
                print("Error retrieving chat contacts from Core Data: \(error)")
            }
        }
    }
}

额外优化建议 #

• 移除ChatsView中@Environment(\.managedObjectContext)的引用，直接通过ViewModel传递上下文，保持数据源单一性。
• 用@MainActor标记ViewModel中更新@Published状态的方法，确保状态更新始终在主队列执行，进一步规避线程问题。

内容的提问来源于stack exchange，提问作者Ray