MVVM中ComboBox SelectedItem绑定始终为null的问题排查与解决

开发MVVM程序时，通过单选按钮切换ComboBox的ItemsSource（绑定string列表），ComboBox能正常显示列表，SelectedIndex更新正常，但SelectedItem绑定值始终为null，调用时抛出System.NullReferenceException。之前在XAML中手动定义ComboBoxItem时该绑定方式可行，希望继续使用SelectedItem而非SelectedIndex解决问题。

代码示例 #

XAML代码 #

<RadioButton Grid.Column="0" Content="List1" IsChecked="{Binding Path=TypeList1, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"/>
<RadioButton Grid.Column="1" Content="List2" IsChecked="{Binding Path=TypeList2, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"/>
<RadioButton Grid.Column="2" Content="List3" IsChecked="{Binding Path=TypeList3, Mode=TwoWay,UpdateSourceTrigger=PropertyChanged}"/>

<ComboBox Margin="5" 
          ItemsSource="{Binding Path=MySource}"
          SelectedItem="{Binding Path=MySelectedItem, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
          SelectedIndex="{Binding Path=MySelectedIndex,Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
          />

C#代码 #

Class MyClass
{
    private list<string> _listType;
    private list<string> _mySource;
    private bool _typeList1;
    private bool _typeList2;
    private bool _typeList3;
    private ComboBoxItem _mySelectedItem;
    private int _mySelectedIndex;
    
    public list<string> ListType
    {
        get{ return _listType;}
        set{ _listType=value; OnPropertyChanged(nameof(ListType));
    }

    public bool TypeList1
    {
        get{return _typeList1;}
        set
        {
            _typeList1=value; 
            OnPropertyChanged(nameof(TypeList1));
            if(value==true)
            {
                MySource=List1;
                TypeList2=false;
                TypeList3=false;
            }   
        }
    }
    public bool TypeList2
    {
        get{return _typeList2;}
        set
        {
            _typeList2=value; 
            OnPropertyChanged(nameof(TypeList2));
            if(value==true)
            {
                MySource=List2;
                TypeList1=false;
                TypeList3=false;
            }   
        }
    }
    public bool TypeList3
    {
        get{return _typeList3;}
        set
        {
            _typeList3=value; 
            OnPropertyChanged(nameof(TypeList3));
            if(value==true)
            {
                MySource=List3;
                TypeList2=false;
                TypeList1=false;
            }   
        }
    }
    
    public list<string> MySource
    {
        get{ return _mySource;}
        set{ _mySource=value; OnPropertyChanged(nameof(MySource));
    }
    public ComboBoxItem MySelectedItem
    {
        get{ return _mySelectedItem;}
        set{ _mySelectedItem=value; OnPropertyChanged(nameof(MySelectedItem));
    }

    public int MySelectedIndex
    {
        get{ return _mySelectedIndex;}
        set{_mySelectedIndex=value; OnPropertyChanged(nameof(MySelectedIndex));
    }

    public List<string> List1=new List<string> {"List1Val1", "List1Val2", "List1Val3",};
    public List<string> List2=new List<string> {"List2Val1", "List2Val2", "List2Val3","List2Val4"};
    public List<string> List3=new List<string> {"List3Val1", "List3Val2", "List3Val3",};
    
    public MyClass()
    {
        MySource= new List<string>();
        ListType= new List<string>();
    }
    
    public void MyFunction()
    {
        string mySelectedValueFromComboBox= MySelectedItem.content.ToString();// 报错位置
    }
}

报错信息 #

System.NullReferenceException: 'Object reference not set to an instance of an object.'
FileName.mySelectedValueFromComboBox.get returned null.

你的MySelectedItem属性类型是ComboBoxItem，但ComboBox的ItemsSource绑定的是List<string>，实际选中项是string类型，不是ComboBoxItem对象，类型不匹配导致SelectedItem绑定失败，值始终为null。之前在XAML手动定义ComboBoxItem时，ItemsSource里的元素是ComboBoxItem类型，所以绑定能正常工作。

1. 将MySelectedItem的类型从ComboBoxItem改为string，和ItemsSource的元素类型保持一致。
2. 移除MyFunction中对ComboBoxItem.Content的调用，直接使用MySelectedItem即可获取选中的字符串值。
3. 切换数据源时重置MySelectedItem为null，避免旧选中值残留引发异常。

C#代码 #

class MyClass : INotifyPropertyChanged
{
    private List<string> _listType;
    private List<string> _mySource;
    private bool _typeList1;
    private bool _typeList2;
    private bool _typeList3;
    private string _mySelectedItem; // 类型改为string
    private int _mySelectedIndex;

    public List<string> ListType
    {
        get { return _listType; }
        set { _listType = value; OnPropertyChanged(nameof(ListType)); }
    }

    public bool TypeList1
    {
        get { return _typeList1; }
        set
        {
            _typeList1 = value;
            OnPropertyChanged(nameof(TypeList1));
            if (value == true)
            {
                MySource = List1;
                MySelectedItem = null; // 切换数据源时重置选中项
                TypeList2 = false;
                TypeList3 = false;
            }
        }
    }

    public bool TypeList2
    {
        get { return _typeList2; }
        set
        {
            _typeList2 = value;
            OnPropertyChanged(nameof(TypeList2));
            if (value == true)
            {
                MySource = List2;
                MySelectedItem = null;
                TypeList1 = false;
                TypeList3 = false;
            }
        }
    }

    public bool TypeList3
    {
        get { return _typeList3; }
        set
        {
            _typeList3 = value;
            OnPropertyChanged(nameof(TypeList3));
            if (value == true)
            {
                MySource = List3;
                MySelectedItem = null;
                TypeList2 = false;
                TypeList1 = false;
            }
        }
    }

    public List<string> MySource
    {
        get { return _mySource; }
        set { _mySource = value; OnPropertyChanged(nameof(MySource)); }
    }

    public string MySelectedItem // 类型改为string
    {
        get { return _mySelectedItem; }
        set { _mySelectedItem = value; OnPropertyChanged(nameof(MySelectedItem)); }
    }

    public int MySelectedIndex
    {
        get { return _mySelectedIndex; }
        set { _mySelectedIndex = value; OnPropertyChanged(nameof(MySelectedIndex)); }
    }

    public List<string> List1 = new List<string> { "List1Val1", "List1Val2", "List1Val3" };
    public List<string> List2 = new List<string> { "List2Val1", "List2Val2", "List2Val3", "List2Val4" };
    public List<string> List3 = new List<string> { "List3Val1", "List3Val2", "List3Val3" };

    public MyClass()
    {
        MySource = new List<string>();
        ListType = new List<string>();
    }

    public void MyFunction()
    {
        // 直接使用MySelectedItem，无需访问Content属性
        string mySelectedValueFromComboBox = MySelectedItem;
        // 可选：添加空值判断避免异常
        if (!string.IsNullOrEmpty(mySelectedValueFromComboBox))
        {
            // 处理选中值的逻辑
        }
    }

    // 实现INotifyPropertyChanged接口的必要代码
    public event PropertyChangedEventHandler PropertyChanged;
    protected void OnPropertyChanged(string propertyName)
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
    }
}

XAML代码 #

XAML无需修改，保持原绑定逻辑即可。

内容的提问来源于stack exchange，提问作者PuddleJumper1357