ASP.NET Core OpenAPI项目电影筛选优化：更简洁实现方案咨询

你的代码功能正常，但手动拼接URL容易产生冗余字符，且代码重复度高。可以借助ASP.NET Core自带的工具类和LINQ来优化，让代码更简洁健壮：

核心优化思路 #

• 用QueryHelpers（来自Microsoft.AspNetCore.WebUtilities命名空间）自动处理URL查询参数拼接，避免手动拼接的错误
• 用LINQ批量转换筛选参数为键值对，减少重复的foreach循环
• 可选：封装筛选参数为实体类，提升代码可读性和扩展性

优化后的代码示例 #

1. 基础优化：使用QueryHelpers和LINQ重构筛选URL构建 #

using Microsoft.AspNetCore.WebUtilities;

// 重构后的筛选URL构建方法
private string GetUrlWithFilter(List<MoviePartial.Genre> genres, List<string> years, List<MoviePartial.Rating> ratings, List<MoviePartial.Country> countries)
{
    var queryParams = new List<KeyValuePair<string, string>>();

    // 批量添加各类型筛选参数
    queryParams.AddRange(genres.Select(g => new KeyValuePair<string, string>("genres.name", g.ToString())));
    queryParams.AddRange(years.Select(y => new KeyValuePair<string, string>("year", y))); // 键名根据实际API调整
    queryParams.AddRange(ratings.Select(r => new KeyValuePair<string, string>("rating", r.ToString()))); // 键名根据实际API调整
    queryParams.AddRange(countries.Select(c => new KeyValuePair<string, string>("premiere.name", c.ToString())));

    // 自动拼接基础URL和查询参数，无需手动处理&符号
    return QueryHelpers.AddQueryString($"{_httpHelperKinopoisk.RequestUrl}/movie/search", queryParams);
}

// 重构后的分页参数拼接方法
public async Task<string> GetMoviesByFilter(string baseFilterUrl, int page = 1, int limit = 10)
{
    var paginationParams = new Dictionary<string, string>
    {
        {"page", page.ToString()},
        {"limit", limit.ToString()}
    };

    // 在已有筛选URL基础上追加分页参数
    var fullUrl = QueryHelpers.AddQueryString(baseFilterUrl, paginationParams);
    
    return await _httpHelperKinopoisk.HttpClient.GetStringAsync(fullUrl);
}

2. 进阶优化：封装筛选参数为实体类 #

如果筛选参数较多，可以封装成实体类，让参数传递更清晰：

// 定义筛选参数实体
public class MovieFilterParams
{
    public List<MoviePartial.Genre> Genres { get; set; } = new();
    public List<string> Years { get; set; } = new();
    public List<MoviePartial.Rating> Ratings { get; set; } = new();
    public List<MoviePartial.Country> Countries { get; set; } = new();
    public int Page { get; set; } = 1;
    public int Limit { get; set; } = 10;
}

// 统一构建完整查询URL
private string BuildMovieSearchUrl(MovieFilterParams filterParams)
{
    var queryParams = new List<KeyValuePair<string, string>>();

    queryParams.AddRange(filterParams.Genres.Select(g => new KeyValuePair<string, string>("genres.name", g.ToString())));
    queryParams.AddRange(filterParams.Years.Select(y => new KeyValuePair<string, string>("year", y)));
    queryParams.AddRange(filterParams.Ratings.Select(r => new KeyValuePair<string, string>("rating", r.ToString())));
    queryParams.AddRange(filterParams.Countries.Select(c => new KeyValuePair<string, string>("premiere.name", c.ToString())));
    queryParams.Add("page", filterParams.Page.ToString());
    queryParams.Add("limit", filterParams.Limit.ToString());

    return QueryHelpers.AddQueryString($"{_httpHelperKinopoisk.RequestUrl}/movie/search", queryParams);
}

// 简化调用方法
public async Task<string> GetMoviesByFilter(MovieFilterParams filterParams)
{
    var fullUrl = BuildMovieSearchUrl(filterParams);
    return await _httpHelperKinopoisk.HttpClient.GetStringAsync(fullUrl);
}

优化优势 #

• 自动处理查询参数的分隔符，避免手动拼接产生的多余&字符（可能导致API解析异常）
• 代码更简洁，通过LINQ批量处理参数，减少重复代码
• 利用官方工具类，逻辑更规范，降低出错概率
• 扩展性更好，新增筛选参数只需添加一行AddRange或实体类属性即可

内容的提问来源于stack exchange，提问作者Vitaliy