Django模型重写delete方法失效问题及解决咨询

问题描述 #

定义了一个Page模型，保存对象时save方法中的print语句可正常触发，但删除对象时delete方法中的print语句无响应，似乎该方法从未被调用。请问该如何正确重写默认的delete方法？

原代码 #

class Page(models.Model):
    image = models.ImageField()
    number = models.PositiveIntegerField(default=0, blank=True, null=True)
    chapter = models.ForeignKey(Chapter, on_delete=models.CASCADE)

    def get_upload_path(self, filename):
        work_slug = self.chapter.volume.work.slug
        translator_name = slugify(self.chapter.volume.translator)
        volume_number = self.chapter.volume.number
        chapter_number = self.chapter.number
        name, extension = filename.rsplit('.', 1)
        return f'media/{work_slug}/{translator_name}/volumes/volume-{volume_number}/chapters/chapter-{chapter_number}/page-{self.number}.{extension}'

    def save(self, *args, **kwargs):
        if not self.pk:
            last_page = self.chapter.page_set.last()
            if last_page:
                self.number = last_page.number + 1
        self.image.name = self.get_upload_path(self.image.name)
        self.image.storage = s3
        print(f"Saving Page with image: {self.image.name}")
        super().save(*args, **kwargs)

    def delete(self, *args, **kwargs):
        print(f"Deleting Page with image: {self.image.name}")

        image_name = self.image.name
        try:
            s3.delete(image_name)
            print(f"Successfully deleted from S3: {image_name}")
        except Exception as e:
            print(f"Error deleting from S3: {e}")

        super().delete(*args, **kwargs)

问题原因 #

Django中，只有调用单个模型实例的delete()方法时，才会触发你重写的模型delete方法；如果使用QuerySet.delete()（比如批量删除、后台admin批量操作、通过filter删除），Django会直接执行SQL删除语句，不会调用每个实例的delete方法，所以你的print语句不会触发。

解决办法 #

办法一：确保调用单个实例的delete方法 #

如果你的删除操作都是针对单个对象，直接调用实例的delete()：

# 正确触发模型delete方法的方式
page = Page.objects.get(pk=1)
page.delete()

但这种方式无法覆盖批量删除的场景。

办法二：使用Django信号处理删除逻辑 #

用pre_delete信号来处理文件删除，不管是单个删除还是批量删除，信号都会触发：

from django.db.models.signals import pre_delete
from django.dispatch import receiver

@receiver(pre_delete, sender=Page)
def delete_page_s3_image(sender, instance, **kwargs):
    print(f"Deleting Page with image: {instance.image.name}")
    image_name = instance.image.name
    try:
        s3.delete(image_name)
        print(f"Successfully deleted from S3: {image_name}")
    except Exception as e:
        print(f"Error deleting from S3: {e}")

把这段代码放在models.py里，或者单独的signals.py文件（记得在app的__init__.py里注册）。

办法三：重写QuerySet的delete方法 #

自定义QuerySet，重写其delete方法，确保批量删除时也执行实例的删除逻辑：

from django.db import models

class PageQuerySet(models.QuerySet):
    def delete(self):
        for obj in self:
            # 调用每个实例的delete方法
            obj.delete()
        # 注意：这里不要调用super().delete()，否则会重复执行SQL删除

class Page(models.Model):
    # 字段定义不变
    image = models.ImageField()
    number = models.PositiveIntegerField(default=0, blank=True, null=True)
    chapter = models.ForeignKey(Chapter, on_delete=models.CASCADE)

    # 指定自定义QuerySet
    objects = PageQuerySet.as_manager()

    # 其他方法（get_upload_path、save）不变

    def delete(self, *args, **kwargs):
        print(f"Deleting Page with image: {self.image.name}")
        image_name = self.image.name
        try:
            s3.delete(image_name)
            print(f"Successfully deleted from S3: {image_name}")
        except Exception as e:
            print(f"Error deleting from S3: {e}")
        super().delete(*args, **kwargs)

这种方式可以让批量删除（比如Page.objects.filter(chapter=xxx).delete()）也触发每个实例的delete方法，但要注意关联删除（比如删除Chapter时级联删除Page）的场景，可能需要额外处理。

推荐方案 #

优先用信号的方式，因为它更符合Django的设计模式，能覆盖所有删除场景，包括级联删除、批量删除、单个删除，逻辑更可靠。

内容的提问来源于stack exchange，提问作者Andrii Frighes