Terraform模块优化：如何用嵌套变量统一条件定义避免重复？

可以通过统一封装条件判断逻辑，将重复的条件只写一次，再从中提取所需变量，大幅简化代码。以下是针对S3和VPC端点的具体优化方案：

一、S3相关变量优化 #

把S3包的存在性判断统一放在一个本地对象中，后续变量直接从该对象提取：

locals {
  # 统一判断S3包是否存在，返回完整配置或空对象
  s3_package = var.s3_existing_package != null ? {
    bucket  = try(var.s3_existing_package.bucket, null)
    key     = try(var.s3_existing_package.key, null)
    version = try(data.aws_s3_object.this.version_id, null)
  } : {}

  # 从统一对象中提取字段，空对象时自动返回null
  s3_bucket         = local.s3_package.bucket
  s3_key            = local.s3_package.key
  s3_object_version = local.s3_package.version
}

二、VPC端点相关变量优化 #

先统一判断VPC端点的启用条件，再基于该结果生成配置对象，最后提取变量：

locals {
  # 统一判断VPC端点是否需要启用
  vpc_endpoint_enabled = var.enable_api_gw && var.api_gw_endpoint_type == "PRIVATE"

  # 启用时返回完整配置，否则返回默认值
  vpc_endpoint_config = local.vpc_endpoint_enabled ? {
    vpc_id                          = try(var.vpc_id, null)
    subnet_ids                      = try(var.vpc_endpoint_subnet_ids, null)
    default_sg_allowed_cidrs        = try(var.vpc_endpoint_default_sg_allowed_cidrs, null)
    additional_security_group_ids   = try(var.vpc_endpoint_additional_security_group_ids, [])
  } : {
    additional_security_group_ids = []
  }

  # 从统一配置中提取所需变量
  vpc_id                                     = local.vpc_endpoint_config.vpc_id
  vpc_endpoint_subnet_ids                    = local.vpc_endpoint_config.subnet_ids
  vpc_endpoint_default_sg_allowed_cidrs      = local.vpc_endpoint_config.default_sg_allowed_cidrs
  vpc_endpoint_additional_security_group_ids = local.vpc_endpoint_config.additional_security_group_ids
}

更简洁的VPC配置写法（可选） #

利用merge函数合并默认值和启用时的配置，进一步精简代码：

locals {
  vpc_endpoint_enabled = var.enable_api_gw && var.api_gw_endpoint_type == "PRIVATE"

  vpc_endpoint_config = merge(
    # 默认值兜底
    { additional_security_group_ids = [] },
    # 启用时覆盖默认配置
    local.vpc_endpoint_enabled ? {
      vpc_id                          = try(var.vpc_id, null)
      subnet_ids                      = try(var.vpc_endpoint_subnet_ids, null)
      default_sg_allowed_cidrs        = try(var.vpc_endpoint_default_sg_allowed_cidrs, null)
      additional_security_group_ids   = try(var.vpc_endpoint_additional_security_group_ids, [])
    } : {}
  )

  # 提取变量（同上）
  vpc_id                                     = local.vpc_endpoint_config.vpc_id
  vpc_endpoint_subnet_ids                    = local.vpc_endpoint_config.subnet_ids
  vpc_endpoint_default_sg_allowed_cidrs      = local.vpc_endpoint_config.default_sg_allowed_cidrs
  vpc_endpoint_additional_security_group_ids = local.vpc_endpoint_config.additional_security_group_ids
}

这样修改后，重复的条件判断只需要维护一次，后续变量取值逻辑更清晰，代码可维护性大幅提升。

内容的提问来源于stack exchange，提问作者Disbalance