Python水火草猜拳游戏while条件异常：目标分数达成后无法结束

你的游戏无法在分数达标时结束，核心存在两个关键问题：

1. 类型不匹配问题 #

targetScore 通过 input() 获取，得到的是字符串类型，但 userScore 和 compScore 是整数类型。字符串与整数直接比较（比如 "3" == 3）永远为False，导致分数达标的结束条件完全失效。

2. While循环逻辑错误 #

原循环条件使用 or 连接，意味着只要任一条件成立就会继续循环——哪怕分数已经达标，只要用户没输入quit，循环就会持续运行。正确逻辑应为：只有当用户没输入quit，且双方都未达到目标分时，才继续游戏，需要用 and 组合条件，并取反分数达标的情况。

修正后的完整代码 #

import random
choices = ["water",
           "grass",
           "fire"]
bestOf = [1, 3, 5, 7]

userChoice = ""
userScore = 0
compScore = 0
# 新增输入验证，确保目标分数合法并转为整数
while True:
    target_input = input("Pick number to play up to (1, 3, 5, or 7): ")
    if target_input.isdigit() and int(target_input) in bestOf:
        targetScore = int(target_input)
        break
    print("Invalid input! Please enter 1, 3, 5, or 7.")

# 修正循环条件：未输入quit，且双方分数都未达标时继续
while userChoice != "quit" and userScore < targetScore and compScore < targetScore:
    compChoice = random.choice(choices)
    userChoice = input("Pick either water, grass, or fire (or 'quit' to exit): ")
    userChoice = userChoice.lower()

    # 优先处理quit指令，避免无效游戏逻辑执行
    if userChoice == "quit":
        print("Final scores: User: %d CPU: %d" %(userScore, compScore))
        print("Thanks for playing!")
        continue

    print ("The CPU called out %s and you called out %s!" %(compChoice, userChoice))
    # 平局判定
    if userChoice == compChoice:
        print("Tie game.")
        print("Scores: User: %d CPU: %d" %(userScore, compScore))
    # 用户获胜判定
    elif (userChoice == "water" and compChoice == "fire") or \
         (userChoice == "grass" and compChoice == "water") or \
         (userChoice == "fire" and compChoice == "grass"):
        print("You win!")
        userScore += 1
        print("Scores: User: %d CPU: %d" %(userScore, compScore))
    # CPU获胜判定
    elif (userChoice == "water" and compChoice == "grass") or \
         (userChoice == "grass" and compChoice == "fire") or \
         (userChoice == "fire" and compChoice == "water"):
        print("You lose!")
        compScore += 1
        print("Scores: User: %d CPU: %d" %(userScore, compScore))
    else:
        print("Invalid choice! Please pick water, grass, fire, or quit.")

# 循环因分数达标结束时，自动显示最终胜负
if userScore >= targetScore or compScore >= targetScore:
    print("\nGame over!")
    print("Final scores: User: %d CPU: %d" %(userScore, compScore))
    print("You won the match!" if userScore > compScore else "CPU won the match!")

额外优化说明 #

• 新增输入验证，防止用户输入非法目标分数
• 将quit判断前置，避免无效的游戏逻辑执行
• 拆分过长的条件表达式，提升代码可读性
• 分数达标结束游戏时，自动展示最终胜负结果

内容的提问来源于stack exchange，提问作者Ice21