C++非void函数返回警告及运行时错误排查（CodeWars场景）

我在完成CodeWars的格斗胜负判断练习题，需要编写返回std::string类型的函数来判定两名格斗者的胜负。在平台运行时出现如下警告及错误：

warning: control may reach end of non-void function [-Wreturn-type]
runtime error: execution reached the end of a value-returning function without returning a value

提示问题出在初始的两个if语句处，但本地IDE编译时没有该警告。请问可能是什么原因导致的？

附代码如下：

std::string declareWinner(Fighter* fighter1, Fighter* fighter2, std::string firstAttacker) {

    //initialize stats to 0
    int firstAttackerHealth{0}, secondAttackerHealth{0}, secondAttackerDamage{0}, firstAttackerDamage{0};
    std::string secondAttacker;

    //decide who is the first attacker and assign stats values
    if (fighter1->getName() == firstAttacker) {
        firstAttacker =fighter1->getName();
        firstAttackerHealth = fighter1->getHealth();
        firstAttackerDamage = fighter1->getDamagePerAttack();

        secondAttacker = fighter2->getName();
        secondAttackerHealth = fighter2->getHealth();
        secondAttackerDamage = fighter2->getDamagePerAttack();

    }
    else if(fighter2->getName() == firstAttacker) {
        firstAttacker = fighter2->getName();
        firstAttackerHealth = fighter2->getHealth();
        firstAttackerDamage = fighter2->getDamagePerAttack();

        secondAttacker = fighter1->getName();
        secondAttackerHealth = fighter1->getHealth();
        secondAttackerDamage = fighter1->getDamagePerAttack();
    }

    cout << firstAttacker << " vs " << secondAttacker << '\n';
    cout << firstAttacker << " has a total of " << firstAttackerHealth << " points of health   '\n'";
    cout << secondAttacker << " has a total of " << secondAttackerHealth << " points of health '\n'";
    cout << "Fight!'\n'";

    //start the combat only if both health values are above 0
    while (firstAttackerHealth > 0 && secondAttackerHealth > 0) {

        //check for attacker health, if greater than 0, then they can damage the opponent
        if (firstAttackerHealth > 0) {
            std::cout << firstAttacker << " punches for " << firstAttackerDamage << '\n';
            secondAttackerHealth-=firstAttackerDamage;
            std::cout << secondAttacker << "'s life is now " << secondAttackerHealth << '\n';
        }
        if (secondAttackerHealth > 0) {

            std::cout << secondAttacker << " punches for " << secondAttackerDamage << '\n';
            firstAttackerHealth -= secondAttackerDamage;
            std::cout << firstAttacker << "'s life is now " << firstAttackerHealth << '\n';
        }
            
        // check for the first attacker with health less than 0 and returns the 
        // other attacker
        if (firstAttackerHealth <= 0) {
            std::cout << firstAttacker << "' health is: " << firstAttackerHealth << " , "
                << firstAttacker << " has lost '\n'";
            return secondAttacker;
        }
        else if (secondAttackerHealth <= 0)
        {
            std::cout << secondAttacker << "' health is: " << secondAttackerHealth << " , "
                << secondAttacker << " has lost '\n'";
            return firstAttacker;
        }
    }
}

问题原因分析 #

1. 分支覆盖不完整
   代码仅处理了firstAttacker匹配fighter1->getName()或fighter2->getName()的情况，若传入的firstAttacker字符串与两者都不匹配，两个if分支都不会执行。此时firstAttackerHealth和secondAttackerHealth会保持初始值0，导致后续while循环条件firstAttackerHealth > 0 && secondAttackerHealth > 0直接不成立，循环跳过，函数走到末尾却没有返回任何值，触发错误。

2. 编译环境配置差异
   本地IDE可能未开启严格编译警告（如-Wreturn-type），或编译器版本、配置不同，没检测到这种无返回值的代码路径。而CodeWars的编译环境开启了更严格的检查规则，运行时会强制验证函数返回值，因此触发了警告和错误。

修复方案 #

• 补充分支默认处理：在两个if分支后添加默认分支，处理firstAttacker不匹配任何格斗者的情况。比如根据题目要求返回空字符串，或抛出异常（若题目保证输入合法，也可添加断言）。
• 添加兜底返回语句：在函数末尾添加一个兜底返回，确保所有代码路径都有返回值，避免极端情况下触发错误。

另外，代码中第一个if分支里firstAttacker = fighter1->getName();是冗余操作（进入分支的条件就是两者相等），可以删除。

修复后的代码示例：

std::string declareWinner(Fighter* fighter1, Fighter* fighter2, std::string firstAttacker) {

    //initialize stats to 0
    int firstAttackerHealth{0}, secondAttackerHealth{0}, secondAttackerDamage{0}, firstAttackerDamage{0};
    std::string secondAttacker;

    //decide who is the first attacker and assign stats values
    if (fighter1->getName() == firstAttacker) {
        firstAttackerHealth = fighter1->getHealth();
        firstAttackerDamage = fighter1->getDamagePerAttack();

        secondAttacker = fighter2->getName();
        secondAttackerHealth = fighter2->getHealth();
        secondAttackerDamage = fighter2->getDamagePerAttack();

    }
    else if(fighter2->getName() == firstAttacker) {
        firstAttackerHealth = fighter2->getHealth();
        firstAttackerDamage = fighter2->getDamagePerAttack();

        secondAttacker = fighter1->getName();
        secondAttackerHealth = fighter1->getHealth();
        secondAttackerDamage = fighter1->getDamagePerAttack();
    }
    else {
        // 处理输入不合法的情况，根据题目要求调整
        return "";
    }

    std::cout << firstAttacker << " vs " << secondAttacker << '\n';
    std::cout << firstAttacker << " has a total of " << firstAttackerHealth << " points of health\n";
    std::cout << secondAttacker << " has a total of " << secondAttackerHealth << " points of health\n";
    std::cout << "Fight!\n";

    //start the combat only if both health values are above 0
    while (firstAttackerHealth > 0 && secondAttackerHealth > 0) {

        //check for attacker health, if greater than 0, then they can damage the opponent
        if (firstAttackerHealth > 0) {
            std::cout << firstAttacker << " punches for " << firstAttackerDamage << '\n';
            secondAttackerHealth -= firstAttackerDamage;
            std::cout << secondAttacker << "'s life is now " << secondAttackerHealth << '\n';
        }
        if (secondAttackerHealth > 0) {
            std::cout << secondAttacker << " punches for " << secondAttackerDamage << '\n';
            firstAttackerHealth -= secondAttackerDamage;
            std::cout << firstAttacker << "'s life is now " << firstAttackerHealth << '\n';
        }
            
        // check for the first attacker with health less than 0 and returns the 
        // other attacker
        if (firstAttackerHealth <= 0) {
            std::cout << firstAttacker << "' health is: " << firstAttackerHealth << " , "
                << firstAttacker << " has lost\n";
            return secondAttacker;
        }
        else if (secondAttackerHealth <= 0)
        {
            std::cout << secondAttacker << "' health is: " << secondAttackerHealth << " , "
                << secondAttacker << " has lost\n";
            return firstAttacker;
        }
    }

    // 兜底返回，避免极端情况走到这里
    return firstAttackerHealth > 0 ? firstAttacker : secondAttacker;
}

内容的提问来源于stack exchange，提问作者Ramirojos