Bat脚本移除变量尾部空格及月份输入验证故障排查

• 新增需求：让用户输入1-12之间的月份并做有效性验证
• 原代码会移除字符串所有空格，现仅需移除变量尾部空格，保留中间空格（比如"This is my text"需保留空格）
• 从网上找到的移除尾部空格的代码单独运行正常，但整合到现有批处理后失效，怀疑和延迟扩展有关

@ECHO OFF
SETLOCAL
rem bat file to prompt for  month, read  name from within file and rename file to that name

rem  get month from user 1 to 12
set "Month="
set /P "Month=Please select month: 1 to 12 "
rem echo %Month%

if %Month% GEQ 1 if %Month% LEQ 12 goto :valid 

if %Month% LSS 1 if %Month% GEQ 13 goto :notvalid 

:notvalid
rem the entry is not valid
echo The number you entered is not valid please try again.
pause
exit

:valid
rem  The entry is valid proceed to renam



SET "sourcedir=D:\GH test files"
SET "filename1=%sourcedir%\test.TXT"
SET "newname="
FOR /f "usebackqskip=4delims=" %%e IN ("%filename1%") DO IF NOT DEFINED newname SET "newname=%%e"
SET "newname=%newname:~46,18%"


REM commented out next line as want to retain spaces within text but remove trailing
REM SET "newname=%newname: =%"

REM - new code added to remove trailing spaces
@echo off
setlocal EnableDelayedExpansion
set "newname=%x: =" & (if "!newname!" neq "" set "x2=!x2! !newname!") & set "newname=%" & set "x2=!x2:~1!"


pause


REN "%filename1%" "Sample_%newname%_Mth%Month%_.txt"


echo Your file has been renamed to "Sample_%newname%_Mth%Month%.txt" you can now close this window.

Pause

@echo off
setlocal EnableDelayedExpansion
set "newname=%x: =" & (if "!newname!" neq "" set "x2=!x2! !newname!") & set "newname=%" & set "x2=!x2:~1!"

1221424124124
141241214141414141xvvvvv24142141414
14214142141421
4114141414141
141241214141414141xvvvvv2414214141400000046976THISISTHETEXT       AXXXXXX

问题点： #

1. 月份验证逻辑错误：第二个if用了逻辑与判断，永远无法触发，且未处理非数字输入的报错情况
2. 移除尾部空格的代码引用了未定义的x变量，嵌套setlocal导致变量无法传递到外层环境
3. 延迟扩展启用时机错误，中途重新开启环境破坏了变量上下文

修正后的完整代码 #

@ECHO OFF
SETLOCAL EnableDelayedExpansion

rem 循环获取1-12的月份输入并验证
:MonthPrompt
set "Month="
set /P "Month=Please select month: 1 to 12 "
rem 用正则匹配验证输入是否为1-12的数字
echo !Month! | findstr /r "^[1-9]$ ^1[0-2]$" >nul
if errorlevel 1 (
    echo The number you entered is not valid please try again.
    pause
    goto :MonthPrompt
)

rem 读取文件第5行内容并提取目标子串
SET "sourcedir=D:\GH test files"
SET "filename1=%sourcedir%\test.TXT"
SET "newname="
FOR /f "usebackq skip=4 delims=" %%e IN ("%filename1%") DO IF NOT DEFINED newname SET "newname=%%e"
SET "newname=!newname:~46,18%"

rem 循环移除尾部空格
:TrimTrailing
if "!newname:~-1!"==" " (
    set "newname=!newname:~0,-1!"
    goto :TrimTrailing
)

rem 执行重命名并提示结果
REN "%filename1%" "Sample_!newname!_Mth!Month!_.txt"
echo Your file has been renamed to "Sample_!newname!_Mth!Month!.txt" you can now close this window.

Pause
ENDLOCAL

修正说明： #

• 月份验证改用findstr正则匹配，确保输入是1-12的有效数字，同时支持循环重新输入，而非直接退出
• 移除尾部空格采用直观的循环判断：检查最后一位是否为空格，是则截断，直到最后一位非空格为止，避免复杂的变量替换逻辑
• 全程启用延迟扩展，保证变量操作的一致性，避免环境嵌套导致的变量丢失问题
• 清理了原代码中多余的重复命令，优化了代码结构

内容的提问来源于stack exchange，提问作者GravyTrain