Rails无法同时更新多层嵌套属性？问题求助

问题场景 #

在Rails项目中，使用深度嵌套属性更新Product模型时，单独更新billing_plan_add_ons_attributes或photos_attributes均正常，但同时传递两者的请求payload时，billing_plan_add_ons的更新操作会被跳过。日志显示请求参数正确，但billing_plan_add_ons的删除/修改未执行。

相关代码片段 #

控制器代码 #

def update
  @product = Product.find(params[:id])
  authorize @product

  if @product.update(product_params)
    render status: :no_content
  else
    render json: { errors: @product.errors }, status: :unprocessable_entity
  end
end

private

def product_params
  params.require(:product).permit(
      :name, :description, :product_type, :category, :fabric_and_care,
      billing_plans_attributes: [
        :id, :_destroy, :updated_at, :name, :amount, :color, :size, :currency, :interval, :interval_count, :intervals_to_bill, :inventory_type, :usage_type, :active, :sold_out, :sibling_coupon_id, :third_sibling_coupon_id, :renewal_plan_id,
        :vendor_sku_id, :vendor_price,
        billing_plan_add_ons_attributes: [:id, :_destroy, :upsell_id],
        photos_attributes: [:id, :_destroy]
      ]
  ).merge(team: current_profile.team)
end

模型关联代码 #

Product模型

has_many :billing_plans, dependent: :destroy, inverse_of: :product
accepts_nested_attributes_for :billing_plans, allow_destroy: true
has_many :photos, through: :billing_plans
has_many :billing_plan_add_ons, through: :billing_plans

BillingPlan模型

belongs_to :product, inverse_of: :billing_plans
has_many :billing_plan_add_ons, class_name: "BillingPlanAddOn", dependent: :destroy, inverse_of: :billing_plan
accepts_nested_attributes_for :billing_plan_add_ons, allow_destroy: true
has_many :upsells, through: :billing_plan_add_ons
has_many :photos, as: :attachable, class_name: "Attachment", dependent: :destroy, inverse_of: :attachable
accepts_nested_attributes_for :photos, allow_destroy: true

自定义photos_attributes= setter（问题根源） #

# 原代码
def photos_attributes=(attributes)
  new_attachment_map = {}
  self.photos = attributes.map do |attachment_attrs|
    dup_attachment = Attachment.find(attachment_attrs['id']).dup
    dup_attachment.save
    new_attachment_map[attachment_attrs['id']] = dup_attachment.id
    dup_attachment
  end

  new_attributes = attributes.map do |attributes|
    attributes['id'] = new_attachment_map[attributes['id']]
    attributes
  end
  super(new_attributes)
end

问题原因 #

原自定义photos_attributes=方法中，self.photos = ...直接替换了整个photos关联集合，这会触发Rails的关联重置逻辑，导致BillingPlan对象的内部状态被修改。当Rails后续处理billing_plan_add_ons_attributes时，关联对象的状态变化会让Rails跳过原本的更新/删除操作。

解决方案 #

修改自定义的photos_attributes=方法，避免直接替换整个关联集合，改为先处理附件复制并替换属性ID，再交给super处理嵌套属性逻辑：

def photos_attributes=(attributes)
  new_attachment_map = {}
  # 先批量复制需要的附件，不直接修改关联集合
  attributes.each do |attachment_attrs|
    next unless attachment_attrs['id'].present?
    dup_attachment = Attachment.find(attachment_attrs['id']).dup
    dup_attachment.save
    new_attachment_map[attachment_attrs['id']] = dup_attachment.id
  end

  # 替换属性中的原始ID为新复制的附件ID
  new_attributes = attributes.map do |attrs|
    if attrs['id'].present? && new_attachment_map.key?(attrs['id'])
      attrs.merge('id' => new_attachment_map[attrs['id']])
    else
      attrs
    end
  end

  # 调用原生的嵌套属性处理逻辑
  super(new_attributes)
end

补充方案（可选） #

如果不想修改setter方法，可以尝试在product_params的billing_plans_attributes中，将billing_plan_add_ons_attributes放在photos_attributes前面，让Rails优先处理add_on的更新：

billing_plans_attributes: [
  # ... 其他属性
  billing_plan_add_ons_attributes: [:id, :_destroy, :upsell_id],
  photos_attributes: [:id, :_destroy]
]

不过此方案依赖参数处理顺序，稳定性不如修改setter方法。

内容的提问来源于stack exchange，提问作者Msencenb