使用RelayCommand时部分场景ActivityIndicator无法运行问题排查

尝试实现RelayCommand内置的IsRunning属性，仅Save按钮命令能正常触发ActivityIndicator，其余场景失效：

• 构造函数中调用BooksServiceAsync无法触发对应ActivityIndicator；
• SelectedBook变更时调用ChaptersServiceAsync无法触发对应ActivityIndicator；
• Save按钮的命令可正常触发ActivityIndicator。

XAML代码 #

<Grid>
    <VerticalStackLayout Padding="20" Spacing="20" VerticalOptions="Fill">
        <Picker Title="Pick Book" 
            ItemsSource="{Binding Books}"
            SelectedItem="{Binding SelectedBook}"
            ItemDisplayBinding="{Binding BookName}">
        </Picker>

        <Picker Title="Pick Chapter"
            ItemsSource="{Binding Chapters}"
            SelectedItem="{Binding SelectedChapter}"
            ItemDisplayBinding="{Binding ChapterName}" />

        <Button Text="Save" 
            Command="{Binding SaveButtonCommand}" />
    </VerticalStackLayout>

    <ActivityIndicator x:Name="booksActivity"
      IsVisible="True"
      IsRunning="{Binding BooksServiceCommand.IsRunning}"/>

    <ActivityIndicator x:Name="chaptersActivity"
      IsVisible="True"
      IsRunning="{Binding ChaptersServiceCommand.IsRunning}"/>

    <ActivityIndicator x:Name="buttonActivity"
      IsVisible="True"
      IsRunning="{Binding SaveButtonCommand.IsRunning}"/>
</Grid>

ViewModel代码 #

public partial class BooksViewModel : ObservableObject
{
    public class Book { public int BookId { get; set; } public string BookName { get; set; } }
    public class Chapter { public string ChapterName { get; set; } }

    [ObservableProperty]
    private Book _selectedBook;

    [ObservableProperty]
    Chapter _selectedChapter;

    [ObservableProperty]
    ObservableCollection<Book> _books;

    [ObservableProperty]
    ObservableCollection<Chapter> _chapters;

    // 构造函数调用无效果
    public BooksViewModel()
    {
       Task.Run(() => BooksServiceAsync());
    }

    [RelayCommand]
    public async Task BooksServiceAsync()
    {
        // Run ActivityIndicator ring here
        await Task.Delay(TimeSpan.FromSeconds(5));
        Books = await Task.Run(() => FetchBooks());
    }

    private ObservableCollection<Book> FetchBooks()
    {
        return  [ 
            new Book { BookName = "Book1"}, 
            new Book { BookName = "Book2" }, 
            new Book { BookName = "Book3" }];
    }

    // SelectedBook变更无效果
    partial void OnSelectedBookChanged(Book value)
    {
        Task.Run(() => ChaptersServiceAsync(value.BookId));
    }

    [RelayCommand]
    public async Task ChaptersServiceAsync(int bookId)
    {
        // Run ActivityIndicator ring here
        await Task.Delay(TimeSpan.FromSeconds(5));
        Chapters = await Task.Run(() => FetchChapters());
    }

    private ObservableCollection<Chapter> FetchChapters()
    {
        return [
            new Chapter { ChapterName = "Chapter1"},
            new Chapter { ChapterName = "Chapter2" },
            new Chapter { ChapterName = "Chapter3" }];
    }

    // 按钮场景正常
    [RelayCommand]
    public async Task SaveButton()
    {
        // Run ActivityIndicator ring here
        await Task.Delay(TimeSpan.FromSeconds(5));
    }
}

核心原因 #

你直接调用了BooksServiceAsync和ChaptersServiceAsync方法，而非通过RelayCommand自动生成的BooksServiceCommand和ChaptersServiceCommand实例执行。RelayCommand的IsRunning属性仅在通过命令实例触发执行时才会自动更新状态，直接调用方法不会触发命令的状态变更逻辑。

另外，嵌套的Task.Run会让执行脱离UI线程，虽然不影响后台操作，但命令状态更新需要回到UI线程才能正确通知绑定控件。

修复步骤 #

1. 构造函数中通过命令实例执行：将Task.Run(() => BooksServiceAsync())替换为_ = BooksServiceCommand.ExecuteAsync(null);（构造函数不能标记为async，用此方式避免阻塞UI初始化）。
2. SelectedBook变更时通过命令实例执行：将Task.Run(() => ChaptersServiceAsync(value.BookId))替换为_ = ChaptersServiceCommand.ExecuteAsync(value.BookId);，触发命令状态更新。
3. 移除不必要的Task.Run嵌套：方法内部的await Task.Run(...)可简化，异步方法内直接调用同步逻辑即可，无需额外包装。

修改后的ViewModel代码 #

public partial class BooksViewModel : ObservableObject
{
    public class Book { public int BookId { get; set; } public string BookName { get; set; } }
    public class Chapter { public string ChapterName { get; set; } }

    [ObservableProperty]
    private Book _selectedBook;

    [ObservableProperty]
    Chapter _selectedChapter;

    [ObservableProperty]
    ObservableCollection<Book> _books;

    [ObservableProperty]
    ObservableCollection<Chapter> _chapters;

    public BooksViewModel()
    {
        // 通过命令实例执行，触发IsRunning状态更新
        _ = BooksServiceCommand.ExecuteAsync(null);
    }

    [RelayCommand]
    public async Task BooksServiceAsync()
    {
        await Task.Delay(TimeSpan.FromSeconds(5));
        // 无需额外Task.Run，直接调用同步方法
        Books = FetchBooks();
    }

    private ObservableCollection<Book> FetchBooks()
    {
        return  [ 
            new Book { BookName = "Book1"}, 
            new Book { BookName = "Book2" }, 
            new Book { BookName = "Book3" }];
    }

    partial void OnSelectedBookChanged(Book value)
    {
        if (value == null) return;
        // 通过命令实例执行，传递参数并触发IsRunning状态更新
        _ = ChaptersServiceCommand.ExecuteAsync(value.BookId);
    }

    [RelayCommand]
    public async Task ChaptersServiceAsync(int bookId)
    {
        await Task.Delay(TimeSpan.FromSeconds(5));
        // 无需额外Task.Run
        Chapters = FetchChapters();
    }

    private ObservableCollection<Chapter> FetchChapters()
    {
        return [
            new Chapter { ChapterName = "Chapter1"},
            new Chapter { ChapterName = "Chapter2" },
            new Chapter { ChapterName = "Chapter3" }];
    }

    [RelayCommand]
    public async Task SaveButton()
    {
        await Task.Delay(TimeSpan.FromSeconds(5));
    }
}

补充说明 #

RelayCommand的IsRunning会在命令执行开始时自动设为true，执行完成（含异常）后设为false，完全由命令内部管理，无需手动修改。

内容的提问来源于stack exchange，提问作者usefulBee