CLIPS线性方程组三角化函数文件打开错误修复求助

我编写了一个CLIPS函数，目标是读取存储线性方程组系数矩阵的文件，将其转换为三角形式后写入新文件。但执行时出现错误，提示无法识别逻辑名'TRUE'，执行被终止。

错误输出 #

CLIPS> (solve-system "file1" "file3")
[ROUTER1] Logical name 'TRUE' was not recognized by any routers.
[PRCCODE4] Execution halted during the actions of deffunction 'solve-system'.
FALSE

原函数代码 #

; 原代码缺少deffunction定义，变量作用域混乱
(bind ?input (open ?input-filename "r"))
(bind ?output (open ?output-filename "w"))
(if (not ?input)
   then
   (printout t "Error of opening " ?input-filename crlf)
   (return))

(bind ?matrix (create$))
(while (not (eq (readline ?input) EOF))
   (bind ?line (readline ?input))
   (if (neq ?line nil)
      then
      (bind ?row (create$))
      (bind ?token "")
      (bind ?len (str-length ?line))
      (loop-for-count (?i 1 (+ 1 ?len)) do
         (bind ?char (str-index ?line ?i))
         (if (str-compare ?char " ")
            then
            (if (neq ?token "")
               then
               (bind ?number (string-to-field ?token))
               (if (numberp ?number)
                  then
                  (bind ?row (create$ ?row ?number))
                  (bind ?token "")))
            else
            (bind ?token (str-cat ?token ?char))))
      (if (neq (length$ ?row) 0)
         then
         (bind ?matrix (create$ ?matrix ?row))))

(bind ?num-rows (length$ ?matrix))
(bind ?num-cols (length$ (first$ ?matrix)))

(loop-for-count (?i 1 (+ 1 ?num-cols)) do
   (loop-for-count (?j ?i (- ?num-rows 1)) do
      (bind ?pivot-row (nth$ ?j ?matrix))
      (bind ?pivot (nth$ ?i ?pivot-row))
      (if (neq ?pivot 0)
         then
         (loop-for-count (?k (+ ?j 1) ?num-rows) do
            (bind ?current-row (nth$ ?k ?matrix))
            (bind ?factor (/ (nth$ ?i ?current-row) ?pivot))
            (bind ?scaled-row (create$))
            (loop-for-count (?l 1 (+ 1 ?num-cols)) do
               (bind ?new-value (- (* (nth$ ?l ?pivot-row) ?factor) (nth$ ?l ?current-row)))
               (bind ?scaled-row (create$ ?scaled-row ?new-value)))
            
            (replace$ ?matrix ?k ?k ?scaled-row)
         )
      )
   )
)

(foreach ?row ?matrix do
   (bind ?result "")
   (loop-for-count (?i 1 (+ 1 (length$ ?row))) do
      (bind ?element (nth$ ?i ?row))
      (if (neq ?i 1) then (bind ?result (str-cat ?result " "))) 
      (bind ?result (str-cat ?result ?element)) 
   )
   (printout ?output ?result crlf)
)

(close ?input) 
(close ?output) 

错误原因分析 #

1. 缺少函数定义包裹：原代码未用deffunction声明函数结构，导致参数和变量作用域混乱。
2. 文件读取逻辑错误：while循环中两次调用readline，直接跳过第一行数据，且可能读取到nil引发后续问题。
3. 空格判断逻辑错误：str-compare返回0（相等）、-1或1（不等），原代码直接用返回值作为判断条件，空格字符会返回0（CLIPS中视为假），无法正确分割数字。
4. 字符索引越界：loop-for-count索引到(+1 ?len)，超出字符串最大索引范围，会读取到nil。
5. 文件关闭逻辑不安全：无论文件是否成功打开都执行close，打开失败时会尝试关闭逻辑名FALSE，引发ROUTER1错误。
6. 消元公式错误：原消元公式符号颠倒，导致三角化结果不正确；循环范围超出矩阵有效列数。

修复后的完整代码 #

(deffunction solve-system (?input-filename ?output-filename)
   ; 初始化文件句柄为nil，避免无效关闭
   (bind ?input nil)
   (bind ?output nil)

   ; 打开输入文件并判断是否成功
   (bind ?input (open ?input-filename "r"))
   (if (not ?input)
      then
      (printout t "Error opening input file: " ?input-filename crlf)
      (return FALSE))

   ; 打开输出文件并判断是否成功，失败则关闭输入文件
   (bind ?output (open ?output-filename "w"))
   (if (not ?output)
      then
      (printout t "Error opening output file: " ?output-filename crlf)
      (close ?input)
      (return FALSE))

   ; 读取矩阵数据，修正读取逻辑
   (bind ?matrix (create$))
   (bind ?line (readline ?input))
   (while (neq ?line EOF)
      (if (neq ?line nil)
         then
         (bind ?row (create$))
         (bind ?token "")
         (bind ?len (str-length ?line))
         ; 遍历字符串有效索引范围
         (loop-for-count (?i 1 ?len) do
            (bind ?char (str-index ?line ?i))
            ; 正确判断空格字符
            (if (eq (str-compare ?char " ") 0)
               then
               (if (neq ?token "")
                  then
                  (bind ?number (string-to-field ?token))
                  (if (numberp ?number)
                     then
                     (bind ?row (create$ ?row ?number))
                     (bind ?token "")))
               else
               (bind ?token (str-cat ?token ?char))))
         ; 处理行末尾剩余的数字token
         (if (neq ?token "")
            then
            (bind ?number (string-to-field ?token))
            (if (numberp ?number)
               then
               (bind ?row (create$ ?row ?number))))
         (if (neq (length$ ?row) 0)
            then
            (bind ?matrix (create$ ?matrix ?row))))
      ; 读取下一行
      (bind ?line (readline ?input)))

   ; 检查矩阵是否为空
   (if (eq (length$ ?matrix) 0)
      then
      (printout t "Input file contains no valid matrix data." crlf)
      (close ?input)
      (close ?output)
      (return FALSE))

   ; 获取矩阵行列数
   (bind ?num-rows (length$ ?matrix))
   (bind ?num-cols (length$ (first$ ?matrix)))

   ; 高斯消元转换为三角形式，修正循环范围和消元公式
   (loop-for-count (?i 1 (- ?num-cols 1)) do
      (loop-for-count (?j ?i ?num-rows) do
         (bind ?pivot-row (nth$ ?j ?matrix))
         (bind ?pivot (nth$ ?i ?pivot-row))
         (if (neq ?pivot 0)
            then
            (loop-for-count (?k (+ ?j 1) ?num-rows) do
               (bind ?current-row (nth$ ?k ?matrix))
               (bind ?factor (/ (nth$ ?i ?current-row) ?pivot))
               (bind ?scaled-row (create$))
               (loop-for-count (?l 1 ?num-cols) do
                  ; 修正消元公式顺序
                  (bind ?new-value (- (nth$ ?l ?current-row) (* (nth$ ?l ?pivot-row) ?factor)))
                  (bind ?scaled-row (create$ ?scaled-row ?new-value)))
               ; 更新矩阵行
               (bind ?matrix (replace$ ?matrix ?k ?k ?scaled-row))
            )
            ; 找到主元后跳出循环，提升效率
            (break)
         )
      )
   )

   ; 将三角矩阵写入输出文件
   (foreach ?row ?matrix do
      (bind ?result "")
      (loop-for-count (?i 1 ?num-cols) do
         (bind ?element (nth$ ?i ?row))
         (if (neq ?i 1)
            then
            (bind ?result (str-cat ?result " ")))
         (bind ?result (str-cat ?result ?element)))
      (printout ?output ?result crlf))

   ; 安全关闭文件
   (close ?input)
   (close ?output)
   (return TRUE)
)

关键修复说明 #

• 规范函数结构：用deffunction明确声明函数，规范参数和变量作用域。
• 安全文件操作：分别判断输入/输出文件是否打开成功，失败时及时关闭已打开的文件，避免资源泄漏。
• 修正读取逻辑：单次读取一行并判断EOF，避免跳过数据；处理行末尾剩余的数字token，确保所有数据被读取。
• 正确空格判断：用(eq (str-compare ?char " ") 0)识别空格字符，实现数字分割。
• 修正消元逻辑：调整消元公式顺序保证结果正确，添加break跳出主元查找循环提升效率，缩小循环范围避免无效计算。

内容的提问来源于stack exchange，提问作者user25045928