如何在React登录组件中合并邮箱输入与密码可见性切换函数？

问题背景 #

你需要将登录组件中的handleEmailChange（处理邮箱输入变化并更新眼睛图片）和togglePasswordVisibility（切换密码可见性）两个函数合并为一个，之前尝试合并时出现异常行为。

解决方案思路 #

两个函数的触发场景和参数不同：一个是输入框的onChange事件（携带输入事件对象），另一个是点击事件（无输入相关参数）。因此合并后的函数需要通过标识参数区分要执行的操作逻辑，避免逻辑混淆。

修改后的代码实现 #

import { useState, useEffect } from "react";
import face1 from "../assets/one.png";
import face2 from "../assets/two.png";
import face3 from "../assets/three.png";
import face4 from "../assets/four.png";
import face5 from "../assets/five.png";
import hide from "../assets/six.png";
import show from "../assets/seven.png";

const LoginPage = () => {
  const [email, setEmail] = useState("");
  const [showPassword, setShowPassword] = useState(false);
  const [eyesIndex, setEyesIndex] = useState(0);

  // 合并后的处理函数
  const handleAction = (action, e) => {
    switch(action) {
      case "emailChange":
        const inputValue = e.target.value;
        setEmail(inputValue);
        if (inputValue !== "") {
          setEyesIndex(prevIndex => (prevIndex + 1) % 5);
        }
        break;
      case "togglePassword":
        setShowPassword(prevState => !prevState);
        break;
      default:
        break;
    }
  };

  const handleKeyPress = (e) => {
    if (e.key === "Backspace" && email === "") {
      setEyesIndex(0);
      console.log("Image changed to face1");
    }
  };

  const getPasswordImage = () => {
    return showPassword ? show : hide;
  };

  // 优化：监听eyesIndex变化打印日志，避免异步状态更新导致的日志不准确
  useEffect(() => {
    console.log(`Image changed to face${eyesIndex + 1}`);
  }, [eyesIndex]);

  return (
    <div className="min-h-screen bg-gray-100 flex flex-col items-center justify-center py-12 sm:px-6 lg:px-8">
      <div className="sm:mx-auto sm:w-full flex items-center flex-col sm:max-w-md">
        <h2 className="mt-6 text-center text-3xl font-extrabold text-gray-900">
          Login
        </h2>
        <div className="home-page h-[10rem] w-[15rem] flex items-center">
          <img
            className="mx-auto h-16 w-auto"
            src={[face1, face2, face3, face4, face5][eyesIndex]}
            alt="Eyes"
          />
          <img
            className="mx-auto h-16 w-auto"
            src={getPasswordImage()}
            alt="Password"
          />
        </div>
      </div>

      <div className="mt-8 sm:mx-auto sm:w-full sm:max-w-md">
        <div className="bg-white py-8 px-4 shadow sm:rounded-lg sm:px-10">
          <form className="space-y-6">
            <div>
              <label
                htmlFor="email"
                className="block text-sm font-medium text-gray-700"
              >
                Email address
              </label>
              <div className="mt-1 relative">
                <input
                  id="email"
                  name="email"
                  type="email"
                  autoComplete="email"
                  onKeyDown={handleKeyPress}
                  required
                  value={email}
                  {/* 调用合并后的函数，传入emailChange标识和事件对象 */}
                  onChange={(e) => handleAction("emailChange", e)}
                  placeholder="Email address"
                  className="pl-10 appearance-none block w-full px-3 py-2 border border-gray-300 rounded-md shadow-sm placeholder-gray-400 focus:outline-none focus:ring-blue-500 focus:border-blue-500 sm:text-sm"
                />
                <div className="absolute inset-y-0 right-0 pr-3 flex items-center pointer-events-none">
                  <div className="h-5 w-5 text-gray-400">
                    <i className="fa-regular fa-envelope"></i>
                  </div>
                </div>
              </div>
            </div>

            <div>
              <label
                htmlFor="password"
                className="block text-sm font-medium text-gray-700"
              >
                Password
              </label>
              <div className="mt-1 relative">
                <input
                  id="password"
                  name="password"
                  type={showPassword ? "text" : "password"}
                  autoComplete="off"
                  placeholder="Password"
                  className="pl-10 appearance-none block w-full px-3 py-2 border border-gray-300 rounded-md shadow-sm placeholder-gray-400 focus:outline-none focus:ring-blue-500 focus:border-blue-500 sm:text-sm"
                />
                <div
                  className="absolute inset-y-0 right-0 pr-3 flex items-center cursor-pointer"
                  {/* 调用合并后的函数，传入togglePassword标识 */}
                  onClick={() => handleAction("togglePassword")}
                >
                  <div className="h-5 w-5 text-gray-400">
                    {showPassword ? (
                      <i className="fa-regular fa-eye-slash"></i>
                    ) : (
                      <i className="fa-regular fa-eye"></i>
                    )}
                  </div>
                </div>
              </div>
            </div>
            <div className="flex items-center justify-between">
              <div className="flex items-center">
                <input
                  id="remember-me"
                  name="remember-me"
                  type="checkbox"
                  className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded"
                />
                <label
                  htmlFor="remember-me"
                  className="ml-2 block text-sm text-gray-900"
                >
                  Remember me
                </label>
              </div>

              <div className="text-sm">
                <a
                  href="#"
                  className="font-medium text-blue-600 hover:text-blue-500"
                >
                  Forgot your password?
                </a>
              </div>
            </div>

            <div>
              <button
                type="submit"
                className="w-full flex justify-center py-2 px-4 border border-transparent rounded-md shadow-sm text-sm font-medium text-white bg-blue-600 hover:bg-blue-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-blue-500"
              >
                Log in
              </button>
            </div>
          </form>
        </div>
      </div>
    </div>
  );
};

export default LoginPage;

关键说明 #

1. 通过action标识区分逻辑：合并后的handleAction函数接收第一个参数作为操作类型，根据不同类型执行对应的邮箱输入处理或密码可见性切换逻辑。
2. 优化日志打印：原代码中直接在setEyesIndex后打印日志会因为React状态更新的异步性导致日志不准确，改用useEffect监听eyesIndex变化来打印，确保日志与实际状态一致。
3. 保留函数式更新：状态更新时使用prevState或prevIndex来获取最新状态，避免闭包导致的状态不一致问题。

内容的提问来源于stack exchange，提问作者NewBie