如何在try-catch块中正确处理错误异常？工单创建responder_id场景

你的代码核心问题在于没有区分异常类型，且catch块逻辑混乱，导致无法精准抛出对应异常。下面是具体的修复方案：

1. 先定义自定义异常类 #

用自定义异常区分错误类型，避免所有错误混在同一个\Exception里：

// 无效responder_id专属异常
class InvalidResponderIdException extends \Exception {}

// 工单创建失败通用异常
class TicketCreationFailedException extends \Exception {}

2. 重构try块：精准抛出对应异常 #

去掉原代码中无意义的空foreach，判断错误类型后抛出对应异常：

if ($agent = $this->getAgent()) {
    $data["responder_id"] = $agent;
}

try {
    $response = FreshdeskService::createTicket($data, $this->getTo(), $attachments);
    $success = $response["success"] ?? false;

    if (!$success) {
        $error_response = json_decode($response['response'], true);
        $error_details = $error_response['errors'] ?? [];
        
        // 判断是否为responder_id错误
        $isInvalidResponder = false;
        foreach ($error_details as $error) {
            if ($error['field'] === 'responder_id') {
                $isInvalidResponder = true;
                break; // 找到目标错误后终止循环
            }
        }

        // 分情况抛出异常
        if ($isInvalidResponder) {
            throw new InvalidResponderIdException(
                "Create ticket failed due to invalid responder_id: {$this->getAgent()}. Error details: " . json_encode($error_details)
            );
        } else {
            throw new TicketCreationFailedException(
                "Create ticket failed: From: {$this->getFrom()}, To: {$this->getTo()}, Subject: {$this->subject}, Response: " . json_encode($response["response"] ?? []) . ", Data: " . json_encode($data)
            );
        }
    }
} catch (InvalidResponderIdException $e) {
    // 仅针对responder_id错误执行重试逻辑
    $data['responder_id'] = null;
    $response = FreshdeskService::createTicket($data, $this->getTo(), $attachments);
    Log::info($response);
    $success = $response["success"] ?? false;

    if (!$success) {
        throw new TicketCreationFailedException(
            "Retry ticket creation failed: From: {$this->getFrom()}, To: {$this->getTo()}, Subject: {$this->subject}, Response: " . json_encode($response["response"] ?? []) . ", Data: " . json_encode($data)
        );
    }
    // 重试成功则流程正常结束，不再抛出异常
}

关键修改说明 #

• 自定义异常让上层调用方可以通过instanceof精准判断错误类型，执行不同处理逻辑
• catch块仅捕获InvalidResponderIdException，其他异常直接向上抛出，不会被重试流程干扰
• 移除了原代码中“重试成功后仍抛出原异常”的错误逻辑，重试成功则正常结束流程
• 优化错误判断循环，找到目标错误后立即终止，提升执行效率

内容的提问来源于stack exchange，提问作者JayVch