自定义Windows Forms ComboBox下拉按钮文本更新延迟问题求助

核心问题 #

1. 按钮创建时机错误：ButtonsPanel的选项按钮在OnPaint方法中创建，而OnPaint触发时机不固定，导致第一次打开下拉面板时按钮尚未生成，此时绑定CustomComboBox_MouseClick事件时dropdownPanel.Controls为空，事件根本没绑定上。
2. 文本更新未触发重绘：即使后续绑定了事件，设置DropDownText后没有强制控件刷新，导致文本无法即时显示。

修复步骤 #

1. 重构ButtonsPanel：将控件创建逻辑移出OnPaint

OnPaint仅用于绘制控件外观，不应在此创建子控件。把按钮创建逻辑移到ItemsList的setter中，并新增选中事件实现父子控件通信：

namespace Example.CustomControls
{
    public class ButtonsPanel : Panel
    {
        // 自定义选中事件，让父控件订阅
        public event EventHandler<string> ItemSelected;

        public string[] itemsList = new string[0];

        public string[] ItemsList
        {
            get { return itemsList; }
            set
            {
                this.Controls.Clear();
                itemsList = value;

                // 直接在属性设置时创建按钮
                foreach (string item in itemsList.Reverse())
                {
                    Button itemButton = new Button
                    {
                        Text = item,
                        Height = 21,
                        Dock = DockStyle.Top,
                        TextAlign = ContentAlignment.MiddleLeft,
                        Margin = new Padding(0),
                        Padding = new Padding(0),
                        FlatStyle = FlatStyle.Flat,
                        BackColor = SystemColors.Window,
                    };

                    itemButton.FlatAppearance.BorderSize = 0;
                    itemButton.FlatAppearance.MouseOverBackColor = SystemColors.Highlight;
                    itemButton.FlatAppearance.MouseDownBackColor = SystemColors.Highlight;

                    // 绑定点击事件，触发自定义选中事件
                    itemButton.Click += (s, e) => 
                    {
                        ItemSelected?.Invoke(this, itemButton.Text);
                    };

                    this.Controls.Add(itemButton);
                }

                Refresh();
            }
        }

        public ButtonsPanel()
        {
            Dock = DockStyle.Top;
            Margin = new Padding(0);
            Padding = new Padding(0);
            BorderStyle = BorderStyle.FixedSingle;
            BackColor = SystemColors.Window;
            AutoScroll = true;
            this.Height = 5 * 21; // 固定高度直接在构造函数设置
        }

        protected override void OnPaint(PaintEventArgs e)
        {
            base.OnPaint(e);
            // 仅保留绘制相关操作，移除控件创建逻辑
        }
    }
}

2. 修复CustomComboBox：订阅选中事件，简化逻辑

不再需要在CheckedChanged中绑定/解绑事件，直接订阅ButtonsPanel的ItemSelected事件，设置文本后强制刷新：

namespace Example.CustomControls
{
    public class CustomComboBox : UserControl
    {
        private string dropdownCheckBoxText = "Select Items";
        private string[] dropDownitemsList = new string[0];
        private DropdownCheckBox dropdownCheckBox;
        private ButtonsPanel dropdownPanel;

        public string DropDownButtonText
        {
            get { return dropdownCheckBoxText; }
            set
            {
                dropdownCheckBoxText = value;
                dropdownCheckBox.DropDownText = value;
                dropdownCheckBox.Refresh(); // 设置后强制刷新控件
            }
        }

        public string[] DropDownItemsArray
        {
            get { return dropDownitemsList; }
            set
            {
                dropDownitemsList = value;
                dropdownPanel.ItemsList = value;
                Refresh();
            }
        }

        public CustomComboBox()
        {
            dropdownCheckBox = new DropdownCheckBox()
            {
                DropDownText = dropdownCheckBoxText,
                Dock = DockStyle.Top
            };

            dropdownPanel = new ButtonsPanel();
            // 订阅选中事件，直接更新按钮文本
            dropdownPanel.ItemSelected += DropdownPanel_ItemSelected;

            this.Controls.Add(dropdownCheckBox);
            this.Controls.Add(dropdownPanel);

            dropdownPanel.Visible = false;
            dropdownCheckBox.CheckedChanged += DropDownCheckBox_CheckedChanged;
        }

        private void DropdownPanel_ItemSelected(object sender, string selectedText)
        {
            dropdownCheckBoxText = selectedText;
            dropdownCheckBox.DropDownText = selectedText;
            dropdownCheckBox.Refresh(); // 强制刷新，即时显示新文本
            // 可选：选中后自动关闭下拉面板
            dropdownCheckBox.Checked = false;
        }

        private void DropDownCheckBox_CheckedChanged(object sender, EventArgs e)
        {
            if (dropdownCheckBox.Checked)
            {
                this.Height = dropdownCheckBox.Height + dropdownPanel.Height;
                dropdownPanel.Visible = true;
                dropdownPanel.BringToFront();
            }
            else
            {
                this.Height = dropdownCheckBox.Height;
                dropdownPanel.Visible = false;
                dropdownPanel.SendToBack();
            }
        }

        protected override void OnPaint(PaintEventArgs e)
        {
            base.OnPaint(e);
            this.Height = dropdownCheckBox.Checked 
                ? dropdownCheckBox.Height + dropdownPanel.Height 
                : dropdownCheckBox.Height;
        }
    }
}

3. 优化DropdownCheckBox：移除冗余代码

DropDownText的setter已设置this.Text = value，无需在OnPaint中重复设置，同时添加重绘触发：

namespace Example.CustomControls
{
    public class DropdownCheckBox : CheckBox
    {
        private int initialWidth;
        private string dropdownText;
        private Icon dropdownIcon = Properties.Resources.DropDownArrow;

        public string DropDownText
        {
            get { return dropdownText; }
            set
            {
                dropdownText = value;
                this.Text = value;
                Invalidate(); // 设置后触发重绘
            }
        }

        public DropdownCheckBox()
        {
            TextAlign = ContentAlignment.MiddleLeft;
            Margin = new Padding(0);
            Padding = new Padding(0);
            FlatAppearance.BorderSize = 1;
            FlatStyle = FlatStyle.Flat;
            BackColor = SystemColors.Window;
            Appearance = Appearance.Button;
            FlatAppearance.MouseOverBackColor = SystemColors.Window;
            FlatAppearance.MouseDownBackColor = SystemColors.Window;
            initialWidth = this.Width;
            this.AutoSize = false;
            this.Height = 21; // 固定高度移到构造函数
        }

        protected override void OnPaint(PaintEventArgs e)
        {
            base.OnPaint(e);

            Rectangle dropDownIconRectangle = new Rectangle(this.Width - this.Height + 2, 2, this.Height - 4, this.Height - 4);
            e.Graphics.FillRectangle(new SolidBrush(SystemColors.Control), dropDownIconRectangle);
            e.Graphics.DrawIcon(dropdownIcon, dropDownIconRectangle);
        }
    }
}

关键修复点总结 #

• 禁止在OnPaint中创建子控件，控件创建应放在属性设置或构造函数中。
• 通过自定义事件实现子控件与父控件的通信，避免遍历子控件绑定事件的繁琐逻辑。
• 设置文本后调用Refresh()或Invalidate()强制控件重绘，确保即时更新显示。
• 移除冗余代码（如重复设置Text、不必要的createState变量），简化逻辑结构。

内容的提问来源于stack exchange，提问作者JCB