SwiftData中NewPositionView初始化陷入无限循环问题求助

问题根源 #

1. NewPositionView中不必要的@Bindable：对inaccount使用@Bindable会监听账户对象的所有变化，当新持仓关联到账户时，账户的关系属性更新会触发NewPositionView的刷新，进而引发循环初始化。
2. PositionView查询条件不安全：用账户名称作为查询持仓的条件，不仅可能出现名称重复的情况，还会因账户属性（如持仓关联变化导致的displayTotalValue更新）触发Query的重复初始化，加剧循环问题。

修复方案 #

1. 调整NewPositionView的账户参数 #

移除inaccount的@Bindable修饰，改为常量let，因为我们仅需读取账户信息来关联新持仓，无需修改账户对象：

import SwiftUI
import SwiftData

struct NewPositionView: View {
    @Bindable private var newPositionForm: NewPositionForm
    let inaccount: Accounts // 改为let，移除@Bindable
    @Environment(\.modelContext) private var modelContext
    @Environment(\.dismiss) var dismiss
    
    init(inaccount: Accounts){
        let viewModel = NewPositionForm()
        self.inaccount = inaccount
        newPositionForm = viewModel
    }
    
    var body: some View {
        Form{
            VStack{
                HStack{
                    FormTextField(label: "Position Stock Symbol", value: $newPositionForm.stockSymbol)
                        .padding(.horizontal, 10)
                    DatePicker(selection: $newPositionForm.dateOpened, in: ...Date.now, displayedComponents: .date) { 
                        Text("Position Open Date")
                    }
                }
                Button("Save Position"){
                    let position = Positions(stockSymbol: newPositionForm.stockSymbol, dateOpened: newPositionForm.dateOpened, inaccount: inaccount, currentValue: 0, goalValue: 0, activePosition: true)
                    modelContext.insert(position)
                    dismiss() // 保存后关闭视图，提升体验
                }
            }
        }
    }
}

2. 修改PositionView的查询条件 #

使用账户的persistentModelID（SwiftData模型的唯一标识）作为查询条件，替代账户名称，确保查询准确且避免因账户属性变化触发的重复初始化：

import SwiftUI
import SwiftData

struct PositionView: View {
    @Bindable var account: Accounts
    @Environment(\.modelContext) var modelContext
    @Query private var positions: [Positions]
    
    init(account: Accounts){
        self.account = account
        // 使用persistentModelID构建Predicate，确保查询唯一性
        let accountID = account.persistentModelID
        let predicate = #Predicate<Positions> { position in
            position.inaccount?.persistentModelID == accountID
        }
        _positions = Query(filter: predicate)
    }
    
    var body: some View {
        VStack{
            HStack {
                Text("Account: \(account.name)")
                    .font(.title)
                    .fontDesign(.rounded)
                    .padding(.horizontal, 15)
                    .frame(minWidth: 75, maxWidth: .infinity, alignment: .leading)
                Text("Current Value: \(account.displayTotalValue)")
                    .font(.title)
                    .fontDesign(.rounded)
                    .frame(minWidth: 75, maxWidth: .infinity, alignment: .leading)
            }
            HStack{
                Text("Positions:")
            }
            if positions.isEmpty {
                Text("No Positions for this account exist.")
                    .padding(15)
            } else {
                List{
                    // 直接遍历positions，符合SwiftUI最佳实践
                    ForEach(positions) { position in
                        VStack(alignment: .leading){
                            HStack{
                                Text(position.stockSymbol) // 显示实际持仓符号
                            }
                        }
                    }.onDelete(perform: deletePosition)
                }
            }
        }.toolbar{
            NavigationLink("Add Position", destination: NewPositionView(inaccount: account))
        }
    }
    
    private func deletePosition(indexSet: IndexSet){
        for index in indexSet{
            let position = positions[index]
            modelContext.delete(position)
        }
    }
}

额外优化建议 #

• 在NewPositionView的保存按钮中添加dismiss()，保存持仓后自动关闭视图，提升用户体验。
• PositionView的List遍历直接使用ForEach(positions)而非索引，避免因数组顺序变化导致的UI异常，更符合SwiftData和SwiftUI的设计规范。

内容的提问来源于stack exchange，提问作者Jesse Winters